Re: H8/300 target support patch

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2004-02-17 at 03:40, Bartlomiej Zolnierkiewicz wrote:
> On Monday 16 of February 2004 17:09, Yoshinori Sato wrote:
> > > +static void _outsw(unsigned long addr, void *buf, u32 len)
> > > +{
> > > +	unsigned volatile short *ap = (unsigned volatile short *)addr;
> > > +	unsigned short *bp = (unsigned short *)buf;
> > > +	unsigned short d;
> > > +	while(len--) {
> > > +		d = *bp++;
> > > +		*ap = (d << 8) | (d >> 8);
> > > +	}
> > > +}
> > > +
> > > +static void _insw(unsigned long addr, void *buf, u32 len)
> > > +{
> > > +	unsigned volatile short *ap = (unsigned volatile short *)addr;
> > > +	unsigned short *bp = (unsigned short *)buf;
> > > +	unsigned short d;
> > > +	while(len--) {
> > > +		d = *ap;
> > > +		*bp++ = (d << 8) | (d >> 8);
> > > +	}
> > > +}
> > >
> > > why you don't use outsw() and insw() from include/asm-h8300/io.h?
> >
> > Because bus turns over, insw/outsw is not usable.
>
> Please explain.  I don't understand why outsw()/insw()
> from io.h can't be assigned to hwif->OUTSW/hwif->INSW.

I'd add that the above code is incredibely shitty... Whatever the HW
does, this is not how it should be implemented.