Re: [PATCH] atapi request sense work

[Pat LaVarre <p.lavarre@ieee.org>]

> > we have NOT yet explained
> > how to insert an ATA op x00 "NOP" ...
> > Instead, my kernel goes down during modprobe ata-piix if I try ...

Just to be complete,

I also tried inserting the ATA op x00 only after the first few commands
passed thru.  That also took my kernel down with the same old dmesg:

atapi_error: err x00
atapi_error: ata_tf_to_host
ata_tf_load_pio: feat 0x0 nsect 0x0 lba 0x0 0x0 0x0
ata_tf_load_pio: device 0xA0
ata_exec: ata2: cmd 0x0

I think I'll also again try more direct access thru iopl(3), but I won't
discuss that further here unless I succeed.

Pat LaVarre

--- o/drivers/scsi/libata-core.c	2004-05-30 08:53:41.000000000 -0600
+++ linux-2.6.7-rc2-pel/drivers/scsi/libata-core.c	2004-05-31 09:57:24.000000000 -0600
@@ -2294,6 +2294,44 @@ struct ata_queued_cmd *ata_qc_new_init(s
 	return qc;
 }
 
+static void atapi_error(struct ata_queued_cmd *qc)
...
@@ -2324,6 +2362,13 @@ void ata_qc_complete(struct ata_queued_c
 		} else {
 			cmd->result = SAM_STAT_GOOD;
 		}
+		do {
+			static int pel_trigger = 0;
+			++pel_trigger;
+			DPRINTK("pel_trigger: %d\n", pel_trigger);
+			if (5 <= pel_trigger) {
+				atapi_error(qc);
+			}
+		} while (0);
 
 		qc->scsidone(cmd);
 	}