From: Pat LaVarre <p.lavarre@ieee.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] atapi request sense work
Date: 02 Jun 2004 16:36:48 -0600 [thread overview]
Message-ID: <1086215808.16228.6.camel@patibmrh9> (raw)
In-Reply-To: <1086209532.8016.2.camel@patibmrh9>
[At last, a small success ...]
Yes despite SATAPI we can appear to have in'ned & out'ted task file
registers.
The following bench patch yields the dmesg:
ata_host_intr: BUS_DMA (host_stat 0x24)
xdump: x 06 00 00 00 06 08 00 00 00 00 00 05 00 00 00 00 A0 A0 00 00
ata_host_intr: tf_load
ata_tf_load_pio: feat 0x5 nsect 0x0 lba 0x0 0x33 0x44
ata_tf_load_pio: device 0xA0
ata_host_intr: tf_read
xdump: x 06 00 00 00 06 08 00 00 00 00 00 05 00 00 33 44 A0 A0 00 00
ata_dma_complete: ENTER
That plain hex is an include/linux/ata.h struct ata_taskfile.
The x 05 00 00 33 44 A0 fragment corresponds to the registers that
PATAPI made visible, leading with the x05 DMA IN of DMADIR DMA, ending
with the xA0 select of Device 0, showing the x33:44 alteration.
Pat LaVarre
diff -urp o/include/linux/ata.h linux-2.6.7-rc2-pel/include/linux/ata.h
diff -urp o/include/linux/libata.h linux-2.6.7-rc2-pel/include/linux/libata.h
diff -urp o/drivers/scsi/libata-core.c linux-2.6.7-rc2-pel/drivers/scsi/libata-core.c
--- o/drivers/scsi/libata-core.c 2004-05-30 08:53:41.000000000 -0600
+++ linux-2.6.7-rc2-pel/drivers/scsi/libata-core.c 2004-06-02 16:08:45.742595728 -0600
@@ -2608,6 +2608,22 @@ static void ata_dma_complete(struct ata_
}
/**
+ */
+
+static void xdump(void * vo, int length)
+{
+ unsigned char * uchars = vo;
+ char chars[123];
+ int to = sprintf(chars, "x");
+ int from;
+ for (from = 0; from < length; ++from) {
+ if (((sizeof chars) - to) < 4) break;
+ to += sprintf(&chars[to], " %02X", uchars[from]);
+ }
+ VPRINTK("%s\n", chars);
+}
+
+/**
* ata_host_intr - Handle host interrupt for given (port, task)
* @ap: Port on which interrupt arrived (possibly...)
* @qc: Taskfile currently active in engine
@@ -2636,6 +2652,17 @@ inline unsigned int ata_host_intr (struc
case ATA_PROT_ATAPI_DMA:
host_stat = ata_check_bmdma(ap);
VPRINTK("BUS_DMA (host_stat 0x%X)\n", host_stat);
+do {
+ struct ata_taskfile * tf = &qc->tf;
+ xdump(tf, sizeof *tf);
+ tf->lbam = 0x33;
+ tf->lbah = 0x44;
+ DPRINTK("tf_load\n");
+ ap->ops->tf_load(ap, tf);
+ DPRINTK("tf_read\n");
+ ap->ops->tf_read(ap, tf);
+ xdump(tf, sizeof *tf);
+} while (0);
if (!(host_stat & ATA_DMA_INTR)) {
ap->stats.idle_irq++;
diff -urp o/drivers/scsi/libata-scsi.c linux-2.6.7-rc2-pel/drivers/scsi/libata-scsi.c
next prev parent reply other threads:[~2004-06-02 22:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-30 12:44 [PATCH] atapi request sense work Pat LaVarre
2004-05-30 15:15 ` Pat LaVarre
2004-05-31 16:09 ` Pat LaVarre
2004-06-02 0:01 ` Pat LaVarre
2004-06-02 20:52 ` Pat LaVarre
2004-06-02 22:36 ` Pat LaVarre [this message]
2004-06-02 22:55 ` Jeff Garzik
2004-06-02 23:53 ` Pat LaVarre
2004-06-03 0:30 ` Pat LaVarre
2004-06-03 0:52 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-05-21 18:45 dwm
2004-05-21 20:44 ` Pat LaVarre
2004-05-16 14:19 [PATCH] libata DMADIR support Pat LaVarre
2004-05-16 23:16 ` Jeff Garzik
2004-05-17 18:48 ` Pat LaVarre
2004-05-17 19:08 ` Jeff Garzik
[not found] ` <108482 8840.3211.26.camel@patibmrh9>
2004-05-17 21:32 ` Jeff Garzik
2004-05-17 22:05 ` Pat LaVarre
2004-05-17 22:36 ` Jeff Garzik
2004-05-18 22:40 ` Pat LaVarre
2004-05-18 23:48 ` [PATCH] atapi request sense work Jeff Garzik
2004-05-19 20:35 ` Pat LaVarre
2004-05-19 22:19 ` Jeff Garzik
2004-05-19 22:24 ` Pat LaVarre
2004-05-19 22:27 ` Pat LaVarre
2004-05-19 22:54 ` Pat LaVarre
2004-05-21 1:58 ` Pat LaVarre
[not found] ` <6 E36A 11B-AACB-11D8-8B8A-003065635034@ieee.org>
2004-05-21 2:06 ` Pat LaVarre
2004-05-21 3:05 ` Pat LaVarre
2004-05-21 4:04 ` Jeff Garzik
[not found] ` <1 085153750.6103.33.camel@patibmrh9>
2004-05-21 15:35 ` Pat LaVarre
2004-05-21 15:46 ` Bartlomiej Zolnierkiewicz
2004-05-21 17:59 ` Pat LaVarre
2004-05-21 20:07 ` Pat LaVarre
2004-05-21 21:51 ` Jeff Garzik
2004-05-21 23:12 ` Pat LaVarre
2004-05-21 23:24 ` Pat LaVarre
2004-05-21 23:55 ` Jeff Garzik
2004-05-21 23:57 ` Pat LaVarre
2004-05-21 23:39 ` Pat LaVarre
2004-05-21 23:45 ` Jeff Garzik
2004-05-22 0:06 ` Pat LaVarre
2004-05-22 0:12 ` Pat LaVarre
2004-05-22 0:33 ` Pat LaVarre
2004-05-22 1:11 ` Pat LaVarre
2004-05-26 21:49 ` Pat LaVarre
2004-05-27 23:12 ` Pat LaVarre
2004-05-27 23:32 ` Jeff Garzik
2004-05-27 23:38 ` Pat LaVarre
2004-05-27 23:41 ` Jeff Garzik
2004-05-28 0:13 ` Pat LaVarre
2004-05-28 1:28 ` Pat LaVarre
2004-05-24 15:27 ` Pat LaVarre
2004-05-21 21:59 ` Pat LaVarre
2004-05-21 18:23 ` Danny Cox
2004-05-21 18:39 ` Bartlomiej Zolnierkiewicz
2004-05-21 19:00 ` Danny Cox
2004-05-21 19:08 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086215808.16228.6.camel@patibmrh9 \
--to=p.lavarre@ieee.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox