From: Pat LaVarre <p.lavarre@ieee.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] SATAPI despite no data
Date: 23 Jul 2004 12:51:49 -0600 [thread overview]
Message-ID: <1090608709.3264.12.camel@patibmrh9> (raw)
Jeff G:
Please may we restore the source line quoted below?
I see we lost this source line in the changes since 2.6.7. But if I try
SATAPI expecting no data without this source line, then my ata_piix.ko
promptly dies with such complaints as:
kernel: irq 18: nobody cared!
With this source line, I find I can expect no data, though I still have
to add auto sense to overcome:
kernel: ata2: BUG: timeout without command
I've placed this source line so that (a) we equate case ATA_PROT_ATAPI
with case ATA_PROT_ATAPI_DMA. I could easily instead (b) write case
ATA_PROT_ATAPI as an isolated case or I could (c) try to write case
ATA_PROT_ATAPI as equal with case ATA_PROT_NODATA, if by chance you do
prefer (b) or (c).
Pat LaVarre
diff -urp linux-2.6.8-rc2-bk2/drivers/scsi/libata-core.c linux-2.6.8-rc2-bk2-pel/drivers/scsi/libata-core.c
--- linux-2.6.8-rc2-bk2/drivers/scsi/libata-core.c 2004-07-23 11:53:35.000000000 -0600
+++ linux-2.6.8-rc2-bk2-pel/drivers/scsi/libata-core.c 2004-07-23 12:29:22.000000000 -0600
@@ -2578,6 +2578,7 @@ inline unsigned int ata_host_intr (struc
case ATA_PROT_DMA:
case ATA_PROT_ATAPI_DMA:
+ case ATA_PROT_ATAPI:
/* check status of DMA engine */
host_stat = ata_bmdma_status(ap);
VPRINTK("BUS_DMA (host_stat 0x%X)\n", host_stat);
next reply other threads:[~2004-07-23 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 18:51 Pat LaVarre [this message]
2004-07-28 17:22 ` [PATCH] SATAPI despite no data Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1090608709.3264.12.camel@patibmrh9 \
--to=p.lavarre@ieee.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox