From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org
Subject: Re: How to cleanly setup legacy IDE irq ?
Date: Sat, 02 Oct 2004 14:30:51 +1000 [thread overview]
Message-ID: <1096691450.12039.3.camel@gaston> (raw)
In-Reply-To: <200410011611.16859.bzolnier@elka.pw.edu.pl>
On Sat, 2004-10-02 at 00:11, Bartlomiej Zolnierkiewicz wrote:
> On Friday 01 October 2004 05:51, Benjamin Herrenschmidt wrote:
> > Hi Bart !
>
> Hi!
>
> > I noticed that you are about to absolete the whole lot of IDE
> > default stuff
> >
> > # define ide_default_io_base(index) (0)
> > # define ide_default_irq(base) (0)
> > # define ide_init_default_irq(base) (0)
> >
> > and others...
> >
> > So how do I do to "cleanly" tell the IDE layer that my PCI IDE
> > controller that shows on the PCI bus and is in legacy mode is
> > using some IRQs (14 & 15 typically) that are _not_ the PCI irq
> > line for this device ?
>
> ->init_hwif() hook
>
> i.e. piix.c is handling this with:
>
> if (!hwif->irq)
> hwif->irq = hwif->channel ? 15 : 14;
>
But that is a totally ugly hack ! And requires putting platform specific
knowledge inside the drivers themselves which is even worse...
(In that case, irqs are 20 and 21 for example).
Ben.
next prev parent reply other threads:[~2004-10-02 4:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 3:51 How to cleanly setup legacy IDE irq ? Benjamin Herrenschmidt
2004-10-01 14:11 ` Bartlomiej Zolnierkiewicz
2004-10-02 4:30 ` Benjamin Herrenschmidt [this message]
2004-10-02 14:56 ` Bartlomiej Zolnierkiewicz
2004-10-03 0:33 ` Benjamin Herrenschmidt
2004-10-03 20:54 ` Bartlomiej Zolnierkiewicz
2004-10-03 23:42 ` Benjamin Herrenschmidt
2004-10-04 0:27 ` Bartlomiej Zolnierkiewicz
2004-10-04 1:05 ` Benjamin Herrenschmidt
2004-10-04 1:20 ` Benjamin Herrenschmidt
2004-10-04 21:35 ` Bartlomiej Zolnierkiewicz
2004-10-04 23:27 ` Benjamin Herrenschmidt
2004-10-04 1:27 ` Jeff Garzik
2004-10-04 1:26 ` Benjamin Herrenschmidt
2004-10-04 1:33 ` Jeff Garzik
2004-10-04 1:33 ` Benjamin Herrenschmidt
2004-10-04 21:21 ` Bartlomiej Zolnierkiewicz
2004-10-04 23:26 ` Benjamin Herrenschmidt
2004-10-04 23:56 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096691450.12039.3.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox