From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org
Subject: Re: PATCH: Add fixup functionality to the PCI drivers
Date: Fri, 05 Nov 2004 23:43:56 +0000 [thread overview]
Message-ID: <1099698235.5630.87.camel@localhost.localdomain> (raw)
In-Reply-To: <200411060144.13024.bzolnier@elka.pw.edu.pl>
On Sad, 2004-11-06 at 00:44, Bartlomiej Zolnierkiewicz wrote:
> > > this chunk is not needed
> >
> > Disagree. Look more carefully - we always need to pass d so we can pass
> > d->fixup
>
> siimage is the only user of d->fixup right now,
> it doesn't use ide_setup_pci_devices()
If you think having the two API's differ in whether d->fixup is honoured
is good then I must disagree strongly with your taste in API's - you are
asking for the first person expecting it to work to get burned
next prev parent reply other threads:[~2004-11-06 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 16:40 PATCH: Add fixup functionality to the PCI drivers Alan Cox
2004-11-05 22:13 ` Bartlomiej Zolnierkiewicz
2004-11-05 23:29 ` Alan Cox
2004-11-06 0:44 ` Bartlomiej Zolnierkiewicz
2004-11-05 23:43 ` Alan Cox [this message]
2004-11-06 16:05 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099698235.5630.87.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).