Re: [PATCH v3 3/8] ata: libata: Add ATA_QUIRK_MAX_SEC and convert all device quirks

[Damien Le Moal <dlemoal@kernel.org>]

On 12/1/25 21:35, Niklas Cassel wrote:
> Add a new quirk ATA_QUIRK_MAX_SEC, which has a separate table with device
> specific values.
> 
> Convert all existing device quirks in __ata_dev_quirks to the new format.

...all existing ATA_QUIRK_MAX_SEC_XXX device quirks in...

> Quirks ATA_QUIRK_MAX_SEC_128 and ATA_QUIRK_MAX_SEC_1024 cannot be removed
> yet, since they are also used by libata.force, which functionally, is a
> separate user of the quirks. The quirks will be removed once all users
> have been converted to use the new format.
> 
> The quirk ATA_QUIRK_MAX_SEC_8191 can be removed since it has no equivalent
> libata.force parameter.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

One nit below.

With that,

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

> +struct ata_dev_quirk_value {
> +	const char *model_num;
> +	const char *model_rev;
> +	u64 val;
> +};

Please align the field names with tabs.



-- 
Damien Le Moal
Western Digital Research