From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: list linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [patch 1/4] fix drive->ready_stat for ATAPI
Date: Sun, 16 Jan 2005 15:01:58 +1100 [thread overview]
Message-ID: <1105848118.27411.99.camel@gaston> (raw)
In-Reply-To: <Pine.GSO.4.58.0501160207290.29887@mion.elka.pw.edu.pl>
On Sun, 2005-01-16 at 02:11 +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> ATAPI devices ignore DRDY bit so drive->ready_stat must be set to zero.
> It is currently done by device drivers (including ide-default fake driver)
> but for PMAC driver it is too late as wait_for_ready() may be called during
> probe: probe_hwif()->pmac_ide_dma_check()->pmac_ide_{mdma,udma}_enable()->
> ->pmac_ide_do_setfeature()->wait_for_ready(). Set correct drive->ready_stat
> just after detecting ATAPI device.
Looks good.
Ben.
prev parent reply other threads:[~2005-01-16 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 1:11 [patch 1/4] fix drive->ready_stat for ATAPI Bartlomiej Zolnierkiewicz
2005-01-16 4:01 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105848118.27411.99.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).