From: Arjan van de Ven <arjan@infradead.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
AJ Johnson <blujuice@us.ibm.com>
Subject: Re: [PATCH] serverworks should not take ahold of megaraid'd controllers
Date: Thu, 21 Jul 2005 18:51:00 -0400 [thread overview]
Message-ID: <1121986260.3914.6.camel@localhost.localdomain> (raw)
In-Reply-To: <42E023B2.5030900@us.ibm.com>
On Thu, 2005-07-21 at 15:37 -0700, Darrick J. Wong wrote:
> Hi all,
>
> I've noticed what might be a small bug with the serverworks driver in
> 2.6.12.3. The IBM HS20 blade has a ServerWorks CSB6 IDE controller with
> an optional LSI MegaIDE RAID BIOS (BIOS assisted software raid, iow).
> When this megaide BIOS is enabled on the HS20, the PCI
> subvendor/subdevice IDs on the CSB6 are changed from the default
> (ServerWorks) to IBM. However, the serverworks driver doesn't notice
> this and will attach to the controller anyway, thus allowing raw access
> to the disks in the RAID. An unsuspecting user can then read and write
> whatever they want to the drive, which could very well degrade or
> destroy the array, which is clearly not desirable behavior.
actually this is the RIGHT behavior.
This way dmraid can address the raid format and make the thing work.
Your patch will break it. That is a very bad idea.
So this is a NAK on your patch.
next prev parent reply other threads:[~2005-07-21 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-21 22:37 [PATCH] serverworks should not take ahold of megaraid'd controllers Darrick J. Wong
2005-07-21 22:51 ` Arjan van de Ven [this message]
2005-07-22 0:46 ` Alan Cox
2005-07-22 23:17 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121986260.3914.6.camel@localhost.localdomain \
--to=arjan@infradead.org \
--cc=blujuice@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).