From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h) Date: Mon, 12 Sep 2005 13:35:20 +0100 Message-ID: <1126528520.30449.61.camel@localhost.localdomain> References: <200509102032.j8AKWxMC006246@localhost.localdomain> <4323482E.2090409@pobox.com> <20050910211932.GA13679@kroah.com> <432352A8.3010605@pobox.com> <20050910223333.GF4770@parisc-linux.org> <43236DAE.8000802@pobox.com> <20050911003409.GB25282@colo.lackof.org> <1126400817.30449.22.camel@localhost.localdomain> <20050911013004.GI4770@parisc-linux.org> <1126520241.30449.42.camel@localhost.localdomain> <20050912112130.GB32395@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from clock-tower.bc.nu ([81.2.110.250]:46742 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1750779AbVILMK2 (ORCPT ); Mon, 12 Sep 2005 08:10:28 -0400 In-Reply-To: <20050912112130.GB32395@parisc-linux.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matthew Wilcox Cc: Grant Grundler , Jeff Garzik , Greg KH , Jiri Slaby , Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, linux-ide@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl On Llu, 2005-09-12 at 05:21 -0600, Matthew Wilcox wrote: > > > surely this is worthy of a comment in the code. there's at least 3 > > > people on the cc who're confused bby what it's for. > > > > Thats because someone removed the obvious pci_present() function some > > time ago. > > Huh? Even if we had pci_present(), it still wouldn't be obvious that a > tertiary scan is unsafe on a PCI-based box. Ah sorry - I misunderstood what you meant was not obvious. I sent in the original patch for this so I'll send Bartlomiej a comment update to go with it.