From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jens Axboe <axboe@suse.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
list linux-ide <linux-ide@vger.kernel.org>
Subject: Re: IDE issues with "choose_drive"
Date: Sun, 09 Oct 2005 08:18:33 +1000 [thread overview]
Message-ID: <1128809913.17365.78.camel@gaston> (raw)
In-Reply-To: <58cb370e0510080129i80710c7gc2178b9330a1ee19@mail.gmail.com>
> It seems we need internal ide_dev_do_request(ide_drive_t *, int)
> which will explicitly state which device we want to service as I see
> no sane way to fix the problem in choose_drive().
Not only that, but if you read my blurb, I wonder how even the
non-targetted case can work properly if we ever hit a couple of the code
path in there that either early exit because the elevator returned no
request or the case where we "sleep" a drive to give more time to the
other... I have the feeling that we may "miss" an opportunity to servive
a drive, and thus this drive will stick around with a pending request
not beeing serviced... I reckon those are corner cases, but I feel the
whole thing need some serious revisiting.
> Your workaround is OK for 2.6.14 given that you will document it
> now and later fix it properly for 2.6.15.
Ok. Well, I'm not sure what is the right fix at the moment given the
other issues I described above, but I'm definitely up to doign a proper
fix for 2.6.15 with your help ;)
Ben.
prev parent reply other threads:[~2005-10-08 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 0:36 IDE issues with "choose_drive" Benjamin Herrenschmidt
2005-10-06 1:02 ` Benjamin Herrenschmidt
2005-10-08 1:15 ` Benjamin Herrenschmidt
2005-10-08 8:29 ` Bartlomiej Zolnierkiewicz
2005-10-08 22:18 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128809913.17365.78.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).