linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* PATCH: Explain the PCI bus test we do in IDE
@ 2005-10-21 13:14 Alan Cox
  2005-11-09 23:09 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2005-10-21 13:14 UTC (permalink / raw)
  To: linux-ide, linux-kernel, akpm

Matthew Wilcox asked that this got a comment explaining why it is done
so here it is.

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.14-rc4-mm1/include/asm-i386/ide.h linux-2.6.14-rc4-mm1/include/asm-i386/ide.h
--- linux.vanilla-2.6.14-rc4-mm1/include/asm-i386/ide.h	2005-10-20 16:10:12.000000000 +0100
+++ linux-2.6.14-rc4-mm1/include/asm-i386/ide.h	2005-10-20 16:37:20.000000000 +0100
@@ -41,6 +41,12 @@
 
 static __inline__ unsigned long ide_default_io_base(int index)
 {
+	/*
+	 *	If PCI is present then it is not safe to poke around
+	 *	the other legacy IDE ports. Only 0x1f0 and 0x170 are
+	 *	defined compatibility mode ports for PCI. A user can 
+	 *	override this using ide= but we must default safe.
+	 */
 	if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
 		switch(index) {
 			case 2: return 0x1e8;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Explain the PCI bus test we do in IDE
  2005-10-21 13:14 PATCH: Explain the PCI bus test we do in IDE Alan Cox
@ 2005-11-09 23:09 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-11-09 23:09 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-ide, linux-kernel, akpm

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-09 23:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-21 13:14 PATCH: Explain the PCI bus test we do in IDE Alan Cox
2005-11-09 23:09 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).