Re: [RFC PATCH] pmac ide doesn't properly cleanup hwif when releasing controller

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Sat, 2005-10-29 at 04:48 +0200, Thibaut VARENE wrote:

> I've been investigating the IDE code a bit, and it seems that it generally
> assumes that an interface cannot be released once claimed. Cleaning up the
> hwif without knowing its previous state in pmac.c is a big and potentially
> dangerous job, and there seems to be no generic code interface that would
> provide either a way to properly release an hwif or to clean it up.
> 
> The rationale behind this is related to the value of MAX_HWIFS, which is
> usually pretty low (usually between 2 and 10).
> 
> So the question is "what should be done (and how)"?

Bart, the problem here is indeed the code in pmac IDE that tries to
"release" HWIFs to the core if they are probed empty. For some reason,
it used to work (I think ide-dma used to unconditionally override the
callbacks) but not any more.

Thus my question: Should I

 - Manually in ide-pmac clean up all callbacks & revert everything in
the HWIF when I want to hand it back

 - Call init_hwif_data() despite the nasty comment on top

 - Just don't release the interface...

Ben.