From: James Bottomley <James.Bottomley@SteelEye.com>
To: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
Cc: Timothy Thelin <Timothy.Thelin@wdc.com>,
t.schorpp@gmx.de, usb-storage@lists.one-eyed-alien.net,
linux-ide@vger.kernel.org,
Linux SCSI list <linux-scsi@vger.kernel.org>
Subject: Re: [usb-storage] [Merging ATA passthru] on integrating SMART/ATA-Security in usb-storage driver
Date: Fri, 04 Nov 2005 14:49:55 -0600 [thread overview]
Message-ID: <1131137395.3532.57.camel@mulgrave> (raw)
In-Reply-To: <20051104203004.GF12384@one-eyed-alien.net>
On Fri, 2005-11-04 at 12:30 -0800, Matthew Dharm wrote:
> > What happens if you prevent USB mangling the scsi_level? I think, for
> > the most part, we would handle 0 in about the same way as we handle 2.
> > However, we could gate the if around the CDB[1] mangling as
> >
> > if (scsi_level != SCSI_UNKNOWN && scsi_level <= SCSI_2)
> >
> > which should fix your problem, I think.
>
> A long time ago, usb-storage didn't mangle the scsi_level. And almost
> nothing worked. Without a SCSI level, 6-byte commands get sent; only
> 10-byte commands will do.
That area of the scsi subsystem has been changed significantly ...
mainly for usb storage. I don't believe your assertion about
SCSI_UNKOWN only producing 6 byte CDBs to be correct, the behaviour is
now governed by two scsi_device flags: use_10_for_rw and use_10_for_ms
which you can control in slave configure.
Can you just try it with a modern kernel and see if anything still
breaks?
Thanks,
James
next prev parent reply other threads:[~2005-11-04 20:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 18:30 [usb-storage] [Merging ATA passthru] on integrating SMART/ATA-Security in usb-storage driver Timothy Thelin
2005-11-04 18:58 ` James Bottomley
2005-11-04 20:30 ` Matthew Dharm
2005-11-04 20:49 ` James Bottomley [this message]
2005-11-05 23:55 ` Matthew Dharm
2005-11-06 0:49 ` James Bottomley
2005-11-06 3:38 ` thomas schorpp
2005-11-06 21:58 ` Matthew Dharm
2005-11-06 22:28 ` thomas schorpp
2005-11-06 23:52 ` Patrick Mansfield
2005-11-07 16:59 ` Matthew Dharm
2005-11-07 17:05 ` Matthew Dharm
2005-11-07 17:24 ` Patrick Mansfield
2005-11-07 17:46 ` Alan Stern
2005-11-07 18:06 ` thomas schorpp
2005-11-07 19:33 ` Alan Stern
2005-11-07 20:07 ` thomas schorpp
2005-11-07 17:53 ` Christoph Hellwig
2005-11-07 17:54 ` thomas schorpp
2005-11-07 18:57 ` Patrick Mansfield
2005-11-07 19:53 ` Alan Stern
2005-11-07 20:47 ` Patrick Mansfield
2005-11-07 20:59 ` Alan Stern
2005-11-07 22:05 ` James Bottomley
2005-11-08 17:09 ` Alan Stern
2005-11-08 23:05 ` Mike Anderson
2005-11-09 15:35 ` Alan Stern
2005-12-01 11:35 ` [PATCH] writable scsi_level [was: [Merging ATA passthru] on integrating SMART/ATA-Security in usb-storage driver] Douglas Gilbert
2005-11-08 13:51 ` [usb-storage] [Merging ATA passthru] on integratingSMART/ATA-Security in usb-storage driver Pat LaVarre
2005-11-06 23:15 ` [usb-storage] [Merging ATA passthru] on integrating SMART/ATA-Security " James Bottomley
2005-11-07 18:14 ` Patrick Mansfield
2005-11-04 23:56 ` Andries Brouwer
2005-11-04 23:46 ` Pete Zaitcev
2005-11-05 16:20 ` thomas schorpp
2005-11-05 18:01 ` [usb-storage] [Merging ATA passthru] on integratingSMART/ATA-Security " Pat LaVarre
-- strict thread matches above, loose matches on Subject: below --
2005-11-08 19:50 [usb-storage] [Merging ATA passthru] on integrating SMART/ATA-Security " Timothy Thelin
2005-11-09 9:04 ` thomas schorpp
2005-11-09 9:45 ` thomas schorpp
2005-11-09 10:05 ` thomas schorpp
2005-11-09 13:21 ` Mark Lord
2005-11-09 14:05 ` thomas schorpp
2005-11-07 20:18 Timothy Thelin
2005-11-07 17:51 Timothy Thelin
2005-11-02 22:18 Timothy Thelin
2005-11-02 23:22 ` thomas schorpp
2005-11-02 23:45 ` Matthew Dharm
2005-11-04 4:08 ` James Bottomley
2005-11-04 17:28 ` Matthew Dharm
2005-11-04 18:33 ` James Bottomley
2005-11-04 20:30 ` Matthew Dharm
2005-11-04 20:53 ` James Bottomley
2005-11-02 20:33 Timothy Thelin
2005-11-02 21:55 ` thomas schorpp
2005-11-02 14:08 thomas schorpp
2005-11-02 16:05 ` [usb-storage] " Alan Stern
2005-11-02 19:12 ` thomas schorpp
2005-11-02 19:26 ` Alan Stern
2005-11-02 20:41 ` thomas schorpp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131137395.3532.57.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Timothy.Thelin@wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-scsi@one-eyed-alien.net \
--cc=t.schorpp@gmx.de \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).