linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Assorted bugs in the PIIX drivers
Date: Fri, 25 Nov 2005 14:43:28 +0000	[thread overview]
Message-ID: <1132929808.3298.18.camel@localhost.localdomain> (raw)

I finally got all the documents rounded up to try and redo Jgarzik's
PIIX driver a bit more completely (I'm short MPIIX if anyone has it ?)

I then started reading the docs and the code and noticing a couple of
problems

1.	We set IE1 on PIO0-2 which the docs say is for PIO3+

2.	The ata_piix one (but not the ide/pci one) have shifts wrong so that
the secondary slave timings are half loaded into the primary slave


I'm also not clear if the "no MWDMA0" list has been updated correctly
for the newer chipsets.

I've yet to review the DMA programming, just the PIO so far.


             reply	other threads:[~2005-11-25 14:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-25 14:43 Alan Cox [this message]
2005-11-25 14:53 ` Assorted bugs in the PIIX drivers Alan Cox
2005-11-25 15:36 ` Marc Koschewski
2005-11-25 17:12   ` Alan Cox
2006-05-15 15:12 ` Sergei Shtylyov
2006-05-15 15:59   ` Alan Cox
2006-05-15 18:26     ` Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2005-11-25 15:44 SMALL, Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132929808.3298.18.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).