From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: list linux-ide <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: Crash when inserting media bay CD with 2.6.15-rc3
Date: Thu, 01 Dec 2005 09:39:29 +1100 [thread overview]
Message-ID: <1133390370.16726.82.camel@gaston> (raw)
In-Reply-To: <58cb370e0511300012p2f703ec0wd5ea054d5b7403d6@mail.gmail.com>
On Wed, 2005-11-30 at 09:12 +0100, Bartlomiej Zolnierkiewicz wrote:
> > For your information, the media bay driver, when detecting an IDE
> > device, first waits for the BUSY bit to clear (historical reasons: the
> > IDE driver used not to do it before I fixed it and I never udpated the
> > mediabay driver) and then does:
> >
> > ide_init_hwif_ports(&hw, (unsigned long) bay->cd_base, (unsigned long) 0, NULL);
> > hw.irq = bay->cd_irq;
> > hw.chipset = ide_pmac;
> > bay->cd_index = ide_register_hw(&hw, NULL);
>
> mediabay driver allocates hw_regs_t hw from the stack but doesn't
> clear it before usage (hw->dev was added recently)?
Ah yes, the hw_regs_t in the past was only used temporarily,
ide_register_hw just copied it. I'll have to dig in there and figure out
how things changed. Thanks.
Ben.
prev parent reply other threads:[~2005-11-30 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-30 5:44 Crash when inserting media bay CD with 2.6.15-rc3 Benjamin Herrenschmidt
2005-11-30 8:12 ` Bartlomiej Zolnierkiewicz
2005-11-30 22:39 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133390370.16726.82.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox