From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: PATCH: libata - oldpiix driver
Date: Fri, 16 Dec 2005 21:29:48 +0000 [thread overview]
Message-ID: <1134768589.28761.69.camel@localhost.localdomain> (raw)
In-Reply-To: <20051216205955.GA21669@electric-eye.fr.zoreil.com>
On Gwe, 2005-12-16 at 21:59 +0100, Francois Romieu wrote:
> Alan Cox <alan@lxorguk.ukuu.org.uk> :
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.14-mm2/drivers/scsi/pata_oldpiix.c linux-2.6.14-mm2/drivers/scsi/pata_oldpiix.c
> > --- linux.vanilla-2.6.14-mm2/drivers/scsi/pata_oldpiix.c 1970-01-01 01:00:00.000000000 +0100
> > +++ linux-2.6.14-mm2/drivers/scsi/pata_oldpiix.c 2005-12-07 17:26:37.000000000 +0000
> [...]
> > +static int oldpiix_qc_issue_prot(struct ata_queued_cmd *qc)
> > +{
> [...]
> > + if(adev->dma_mode)
> > + oldpiix_set_dmamode(ap, adev);
> > + else
> > + oldpiix_set_dmamode(ap, adev);
>
> Where is the difference ?
That would be a bug. Should be oldpiix_set_piomode for the second case.
Will go fix it now.
prev parent reply other threads:[~2005-12-16 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 14:48 PATCH: libata - oldpiix driver Alan Cox
2005-12-13 4:52 ` Jeff Garzik
2005-12-16 20:59 ` Francois Romieu
2005-12-16 21:29 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134768589.28761.69.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox