linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org, albertcc@tw.ibm.com
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 08/12] sata_sil24: add hardreset
Date: Tue, 24 Jan 2006 17:05:22 +0900	[thread overview]
Message-ID: <11380899222691-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1138089921565-git-send-email-htejun@gmail.com>

Now that libata is smart enough to handle both soft and hard resets,
add hardreset method.  Note that sil24 hardreset doesn't supply
signature; still, the new reset mechanism can make good use of it.

Signed-off-by: Tejun Heo <htejun@gmail.com>

---

 drivers/scsi/sata_sil24.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

873ad4e86a46fa83982f694d56d2b9e52d0c2b6a
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index f884c31..f2a4e01 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -484,9 +484,18 @@ static int sil24_softreset(struct ata_po
 	return 0;
 }
 
+static int sil24_hardreset(struct ata_port *ap, int verbose,
+			   unsigned int *class)
+{
+	unsigned int dummy_class;
+
+	/* sil24 doesn't report device signature after hard reset */
+	return sata_std_hardreset(ap, verbose, &dummy_class);
+}
+
 static int sil24_probe_reset(struct ata_port *ap, unsigned int *classes)
 {
-	return ata_drive_probe_reset(ap, sil24_softreset, NULL,
+	return ata_drive_probe_reset(ap, sil24_softreset, sil24_hardreset,
 				     ata_std_postreset, classes);
 }
 
-- 
1.1.3



  parent reply	other threads:[~2006-01-24  8:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24  8:05 [PATCHSET] libata: new reset mechanism, take#2 Tejun Heo
2006-01-24  8:05 ` [PATCH 01/12] libata: export ata_busy_sleep Tejun Heo
2006-01-27  4:18   ` Jeff Garzik
2006-01-24  8:05 ` [PATCH 05/12] libata: implement standard reset component operations and ->probe_reset Tejun Heo
2006-01-28  1:58   ` Jeff Garzik
2006-01-24  8:05 ` [PATCH 09/12] ata_piix: convert pata to new reset mechanism Tejun Heo
2006-01-24  8:05 ` [PATCH 12/12] ahci: add softreset Tejun Heo
2006-01-24  8:05 ` [PATCH 06/12] sata_sil: convert to new reset mechanism Tejun Heo
2006-01-28 18:09   ` Jeff Garzik
2006-01-28 18:27     ` Jeff Garzik
2006-01-28 23:17     ` Tejun
2006-01-29  2:41       ` Jeff Garzik
2006-01-24  8:05 ` [PATCH 03/12] libata: new ->probe_reset operation Tejun Heo
2006-01-24  8:05 ` Tejun Heo [this message]
2006-01-24  8:05 ` [PATCH 02/12] libata: modify ata_dev_try_classify Tejun Heo
2006-01-27  4:20   ` Jeff Garzik
2006-01-24  8:05 ` [PATCH 11/12] ahci: convert to new reset mechanism Tejun Heo
2006-01-24  8:05 ` [PATCH 10/12] ata_piix: convert sata " Tejun Heo
2006-01-24  8:05 ` [PATCH 04/12] libata: implement ata_drive_probe_reset() Tejun Heo
2006-01-28  1:58   ` Jeff Garzik
2006-01-24  8:05 ` [PATCH 07/12] sata_sil24: convert to new reset mechanism Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11380899222691-git-send-email-htejun@gmail.com \
    --to=htejun@gmail.com \
    --cc=albertcc@tw.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).