linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mathieu Chouquet-Stringer <mchouque@free.fr>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com, Mark Lord <lkml@rtr.ca>
Subject: Re: libata-core and pccard CF card reader
Date: Mon, 06 Feb 2006 22:50:09 +0000	[thread overview]
Message-ID: <1139266210.10437.56.camel@localhost.localdomain> (raw)
In-Reply-To: <20060206221923.GA12063@localhost>

On Llu, 2006-02-06 at 23:19 +0100, Mathieu Chouquet-Stringer wrote:
> ata id isn't ata, 0x848a

848A is CFA from memory. Probably it should be tested for and treated
either as disk, or quite possibly a new class.

> ATA documents, I found it's in fact a known ID and is defined as:
> "CompactFlash™Association (CFA) feature set" (found in a bunch of
> different working drafts of ATA-x).

Yes it has its own spec which is ATA plus other bits.

> - if it isn't, should we OR it with something like
>   || dev->id[0] == 0x848a

I think you want to add an "is_cfa" type macro and check it too

> - or should we just test bit 7 of word 0 ("removable media device")?
> - or did I just open a new can of worms that will lead to adding a new
>   subclass of device (CFA feature set) in ata_dev_identify?

We know from dev->id that it is CFA so we can probably just call it a
disk


  reply	other threads:[~2006-02-06 22:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-06 22:19 libata-core and pccard CF card reader Mathieu Chouquet-Stringer
2006-02-06 22:50 ` Alan Cox [this message]
2006-02-07 21:17   ` Mathieu Chouquet-Stringer
  -- strict thread matches above, loose matches on Subject: below --
2006-02-01 10:31 Mathieu Chouquet-Stringer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1139266210.10437.56.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=mchouque@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).