From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 2/9] libata: kill SError clearing in sata_std_hardreset().
Date: Fri, 10 Feb 2006 23:58:48 +0900 [thread overview]
Message-ID: <11395835282675-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11395835282719-git-send-email-htejun@gmail.com>
Don't clear SError in sata_std_hardreset(). This makes hardreset act
identically to ->phy_reset register-wise.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
24bff807a5f2bed38aadb4b8aa25bc40791bf2aa
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 8424bd9..38e72c1 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -2018,8 +2018,6 @@ int ata_std_softreset(struct ata_port *a
*/
int sata_std_hardreset(struct ata_port *ap, int verbose, unsigned int *class)
{
- u32 serror;
-
DPRINTK("ENTER\n");
/* Issue phy wake/reset */
@@ -2034,10 +2032,6 @@ int sata_std_hardreset(struct ata_port *
/* Bring phy back */
sata_phy_resume(ap);
- /* Clear SError */
- serror = scr_read(ap, SCR_ERROR);
- scr_write(ap, SCR_ERROR, serror);
-
/* TODO: phy layer with polling, timeouts, etc. */
if (!sata_dev_present(ap)) {
*class = ATA_DEV_NONE;
--
1.1.5
next prev parent reply other threads:[~2006-02-10 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 14:58 [PATCHSET] libata: various fixes related to EH, take #4 Tejun Heo
2006-02-10 14:58 ` [PATCH 6/9] ata_piix: convert pata to new reset mechanism Tejun Heo
2006-02-11 23:29 ` Jeff Garzik
2006-02-10 14:58 ` [PATCH 3/9] sata_sil: convert " Tejun Heo
2006-02-10 14:58 ` [PATCH 5/9] sata_sil24: add hardreset Tejun Heo
2006-02-10 14:58 ` [PATCH 1/9] libata: make new reset act identical to ->phy_reset register-wise Tejun Heo
2006-02-10 15:30 ` Jeff Garzik
2006-02-10 14:58 ` [PATCH 4/9] sata_sil24: convert to new reset mechanism Tejun Heo
2006-02-10 14:58 ` Tejun Heo [this message]
2006-02-10 14:58 ` [PATCH 7/9] ata_piix: convert sata " Tejun Heo
2006-02-11 23:30 ` Jeff Garzik
2006-02-10 14:58 ` [PATCH 9/9] ahci: add softreset Tejun Heo
2006-02-10 14:58 ` [PATCH 8/9] ahci: convert to new reset mechanism Tejun Heo
2006-02-10 15:01 ` Sorry, wrong PATCHSET name, it should be [PATCHSET] libata: various fixes related to EH, take #4 Tejun Heo
2006-02-10 15:04 ` Gee, wrong again. libata: [PATCHSET] libata: new reset mechanism, take#4 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11395835282675-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).