From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: RFC: Compact Flash True IDE Mode Driver
Date: Tue, 14 Feb 2006 16:58:11 +0000 [thread overview]
Message-ID: <1139936291.10394.47.camel@localhost.localdomain> (raw)
In-Reply-To: <58cb370e0602130235h3ab521cep47584ee634e8fc7f@mail.gmail.com>
On Llu, 2006-02-13 at 11:35 +0100, Bartlomiej Zolnierkiewicz wrote:
> > +static void cfide_outsl(unsigned long port, void *addr, u32 count)
> > +{
> > + panic("outsl unsupported");
> > +}
>
> This will panic as soon as somebody tries to enable 32-bit I/O
> using hdparm. Please add ide_hwif_t.no_io_32bit flag and teach
> ide-disk.c:ide_disk_setup() about it (separate patch).
Seems a lot of effort for little reward. Just make cfide_outsl generate
word sized I/O instead. Ditto insl. Or even leave the panic. Only
superusers can hack around with that value and they can equally crash
the box a thousand other ways.
Alan
next prev parent reply other threads:[~2006-02-14 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 7:19 RFC: Compact Flash True IDE Mode Driver Kumar Gala
2006-02-06 4:13 ` Benjamin Herrenschmidt
2006-02-13 10:35 ` Bartlomiej Zolnierkiewicz
2006-02-13 16:30 ` Kumar Gala
2006-02-13 16:53 ` Bartlomiej Zolnierkiewicz
2006-02-13 19:45 ` Kumar Gala
2006-02-13 20:21 ` Bartlomiej Zolnierkiewicz
2006-02-13 22:13 ` Kumar Gala
2006-02-13 22:35 ` Bartlomiej Zolnierkiewicz
2006-02-14 14:57 ` Kumar Gala
2006-02-14 15:57 ` Bartlomiej Zolnierkiewicz
2006-02-14 16:07 ` Kumar Gala
2006-02-14 16:24 ` Bartlomiej Zolnierkiewicz
2006-02-14 16:58 ` Alan Cox [this message]
2006-02-14 16:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139936291.10394.47.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).