linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Cc: htejun@gmail.com
Subject: [PATCHSET] libata: reorganize ata_dev_identify()
Date: Wed, 15 Feb 2006 18:24:09 +0900	[thread overview]
Message-ID: <11399954493467-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: 


Hello, Jeff.  Hello, Albert.

This patchset is the third part of divided 'reorganize configuration
and implement revalidation' patchset[1].  The first[2] and second[3]
parts made into #upstream lately.

This patchset is against
  the current upstream (254a5c45f8e53775a1e1dd7498a8dcd665341f1e)
  + rename ata_dev_id_[c_]string() patch [4]

Note: Jeff, I generated patches over the rename patch as the patch
      make naming not only shorter but also more consistent.  If you
      don't like the rename, I'll regenerate this patchset without it.

This patchset concentrates on reorganizing ata_dev_identify() into
ata_dev_read_id() and ata_dev_configure() such that those functions
can be also be used for revalidation and other purposes.

Also, both functions don't directly take devices or ports offline.
They just report failures to upper layers and determining whether to
take devices/ports offline is the responsibility of upper layer
driving logic.

Other than failure case handling, reorganized configuration code
should be functionality-wise identical to ata_dev_identify().

Thanks.

--
tejun

[1] http://article.gmane.org/gmane.linux.ide/7632
[2] http://article.gmane.org/gmane.linux.ide/7977
[3] http://article.gmane.org/gmane.linux.ide/7981
[4] http://article.gmane.org/gmane.linux.ide/7997



             reply	other threads:[~2006-02-15  9:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-15  9:24 Tejun Heo [this message]
2006-02-15  9:24 ` [PATCH 2/7] libata: convert dev->id to pointer Tejun Heo
2006-02-15  9:24 ` [PATCH 6/7] libata: fold ata_dev_config() into ata_dev_configure() Tejun Heo
2006-02-20 10:41   ` Jeff Garzik
2006-02-15  9:24 ` [PATCH 5/7] libata: separate out ata_dev_configure() Tejun Heo
2006-02-20 10:37   ` Jeff Garzik
2006-02-15  9:24 ` [PATCH 4/7] libata: kill ata_dev_reread_id() Tejun Heo
2006-02-20 10:35   ` Jeff Garzik
2006-02-15  9:24 ` [PATCH 7/7] libata: reorganize ata_bus_probe() Tejun Heo
2006-02-20 10:43   ` Jeff Garzik
2006-02-20 15:16     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11399954493467-git-send-email-htejun@gmail.com \
    --to=htejun@gmail.com \
    --cc=albertcc@tw.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).