From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 4/4] libata: revalidate after transfer mode configuration
Date: Wed, 15 Feb 2006 19:02:45 +0900 [thread overview]
Message-ID: <11399977652003-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11399977652752-git-send-email-htejun@gmail.com>
Revalidate device after transfer mode configuration. This also makes
dev->id up-to-date.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-core.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
4580280ce48d62d2d801cd427e6194f9ab56e84b
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 54ed8fd..c971c15 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1620,6 +1620,12 @@ static void ata_dev_set_mode(struct ata_
idx = ofs + dev->xfer_shift;
WARN_ON(idx >= ARRAY_SIZE(xfer_mode_str));
+ if (ata_dev_revalidate(ap, dev, 0)) {
+ printk(KERN_ERR "ata%u: failed to revalidate after set "
+ "xfermode, disabled\n", ap->id);
+ ata_port_disable(ap);
+ }
+
DPRINTK("idx=%d xfer_shift=%u, xfer_mode=0x%x, base=0x%x, offset=%d\n",
idx, dev->xfer_shift, (int)dev->xfer_mode, (int)base, ofs);
--
1.1.5
next prev parent reply other threads:[~2006-02-15 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 10:02 [PATCHSET] libata: implement and use ata_dev_revalidate() Tejun Heo
2006-02-15 10:02 ` Tejun Heo [this message]
2006-02-20 10:51 ` [PATCH 4/4] libata: revalidate after transfer mode configuration Jeff Garzik
2006-02-20 15:19 ` Tejun Heo
2006-02-20 22:00 ` Jeff Garzik
2006-02-15 10:02 ` [PATCH 3/4] libata: implement ata_dev_revalidate() Tejun Heo
2006-02-15 10:02 ` [PATCH 1/4] libata: re-initialize parameters before configuring Tejun Heo
2006-02-20 10:49 ` Jeff Garzik
2006-02-20 10:48 ` [PATCHSET] libata: implement and use ata_dev_revalidate() Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-03-01 8:20 [PATCHSET] libata: implement and use ata_dev_revalidate(), take #2 Tejun Heo
2006-03-01 8:20 ` [PATCH 4/4] libata: revalidate after transfer mode configuration Tejun Heo
2006-03-03 22:42 ` Jeff Garzik
2006-03-05 8:55 [PATCHSET] libata: implement and use ata_dev_revalidate(), take #3 Tejun Heo
2006-03-05 8:55 ` [PATCH 4/4] libata: revalidate after transfer mode configuration Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11399977652003-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).