From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: jgarzik@pobox.com, albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] libata: implement per-dev xfer masks
Date: Sun, 12 Mar 2006 13:37:26 +0000 [thread overview]
Message-ID: <1142170646.18565.3.camel@localhost.localdomain> (raw)
In-Reply-To: <11421469551948-git-send-email-htejun@gmail.com>
On Sul, 2006-03-12 at 16:02 +0900, Tejun Heo wrote:
> I marked with comment where the mode filtering for low level drivers
> should be done but I'm not sure how the interface should look like.
Currently the libata pata patch code calls a filter function if present
which returns an updated bitmap for the mode type. I did that because we
need to combine the cable, bridge, core and chip specific rules neatly
and not have one forcing a mode the other cannot do.
> ->pre_set_mode(ap) is okay but then the LLDD should iterate over all
> devices. Maybe ->pre_set_mode(ap, dev) or ->filter_xfer_mask(ap, dev)?
Providing
1. The proposed speeds are set for both devices on the cable before the
call.
2. We reselect the speed of both devices on changedown or hotplug
then we should be just fine.
next prev parent reply other threads:[~2006-03-12 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 7:02 [PATCHSET] libata: implement per-dev xfer masks Tejun Heo
2006-03-12 7:02 ` [PATCH 2/4] libata: implement ata_dev_init() Tejun Heo
2006-03-13 6:19 ` Tejun Heo
2006-03-13 8:26 ` Jeff Garzik
2006-03-13 9:25 ` Tejun Heo
2006-03-12 7:02 ` [PATCH 3/4] libata: add per-dev pio/mwdma/udma_mask Tejun Heo
2006-03-13 8:29 ` Jeff Garzik
2006-03-13 9:30 ` Tejun Heo
2006-03-13 9:52 ` Jeff Garzik
2006-03-13 10:09 ` Tejun Heo
2006-03-13 10:13 ` Jeff Garzik
2006-03-13 10:24 ` Tejun Heo
2006-03-21 1:56 ` Jeff Garzik
2006-03-21 10:25 ` Alan Cox
2006-03-12 7:02 ` [PATCH 1/4] libata: implement ata_unpack_xfermask() Tejun Heo
2006-03-13 8:23 ` Jeff Garzik
2006-03-12 7:02 ` [PATCH 4/4] libata: make per-dev transfer mode limits per-dev Tejun Heo
2006-03-13 8:30 ` Jeff Garzik
2006-03-13 9:33 ` Tejun Heo
2006-03-12 13:37 ` Alan Cox [this message]
2006-03-13 6:12 ` [PATCHSET] libata: implement per-dev xfer masks Tejun Heo
2006-03-13 11:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142170646.18565.3.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).