linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk,
	linux-ide@vger.kernel.org, htejun@gmail.com
Subject: [PATCHSET] libata: implement per-dev xfer masks, take#2
Date: Fri, 24 Mar 2006 14:07:49 +0900	[thread overview]
Message-ID: <11431768691564-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: 

Hello, all.

This is the second take of add-per-dev-pio-mwdma-udma_mask patchset.
Changes from the last take[1] are...

* %02 implement-ata_dev_init patch is removed and %03 is updated
  accordingly.

The patchset is against the current #upstream[2].

I tried to think of a simple way to use single xfer_mask for all
masks, but couldn't.  The problem is that the masks are used in
several different ways affecting specific parts of the mask.  When
composing transfer xfer_mask, it's best if they can be simply bit-wise
or'ed, but we can't use the same mask values when trying to limit
trasnfer mode because bits for other transfer modes will be turned
off.  We're gonna have to use different masks for different purposes
or use mask manipulating wrappers.

So, for the time being, LLDD's are left with three separate masks.  If
anyone can think of a pretty way to convert them, please, go ahead.
We also need to sort out transfer mask constants, the naming is
somewhat inconsistent.

Thanks.

--
tejun

[1] http://article.gmane.org/gmane.linux.ide/8705
[2] 2cc432eed0491df66e14b578139bba2c75fb3f9a



             reply	other threads:[~2006-03-24  5:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-24  5:07 Tejun Heo [this message]
2006-03-24  5:07 ` [PATCH 1/3] libata: implement ata_unpack_xfermask() Tejun Heo
2006-03-24  5:07 ` [PATCH 3/3] libata: make per-dev transfer mode limits per-dev Tejun Heo
2006-03-24  5:07 ` [PATCH 2/3] libata: add per-dev pio/mwdma/udma_mask Tejun Heo
2006-03-24 14:30   ` Jeff Garzik
2006-03-25  2:14     ` [PATCH] libata: add FIXME above ata_dev_xfermask() Tejun Heo
2006-03-25  4:09       ` Jeff Garzik
2006-03-25  5:28         ` [PATCH] libata: kill trailing whitespace Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11431768691564-git-send-email-htejun@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).