Re: [PATCH 2/2] libata: add @disable_on_err argument to ata_set_mode()

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Gwe, 2006-03-24 at 23:03 -0500, Jeff Garzik wrote:
> BTW, got any PATA hardware lying about?  Since you're wandering into 
> xfer mode territory, it would better to test PATA than SATA, as xfer 
> mode matters more in the PATA realm.  Intel PATA should be fairly easy 
> to find, covered by ata_piix, and all the docs are on developer.intel.com.

I've got a fair amount of PATA stuff. If you want to play with failed
devices I'd suggest the best test device to work with is actually
something like the SIL680 with shared address setup. 

I've been watching the changes so far and the overall direction looks
right to me. As far as I can see from the PATA side of things the "we
care about another horked device on the bus" situation is

a) Extremely rare (I've almost never seen it on drivers/ide reports)
b) Usually a controller programming screwup (so wants fixing there)
c) With very few exceptions needs no special handling.

I can find no case where a set mode failure followed by a switch to PIO
0 on the controller for that device (which is right - the device didnt
switch so its in the old mode....), doesn't do the right thing.

Alan