From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: implement ata_dev_enabled and disabled()
Date: Mon, 27 Mar 2006 12:17:37 +0100 [thread overview]
Message-ID: <1143458257.4970.18.camel@localhost.localdomain> (raw)
In-Reply-To: <20060325235732.GA23222@htj.dyndns.org>
On Sul, 2006-03-26 at 08:57 +0900, Tejun Heo wrote:
> Can you elaborate how ata_dev_pair() is broken by this patch?
> ata_dev_present() is simply renamed to ata_dev_enabled().
> ata_dev_disabled() only differenciates the conditions where
> ata_dev_present() used to think there was no device. There should be
> no behavior change to existing code.
Some of the drivers want one sematic some want the other, and
ata_dev_pair is now confusing. Needs a pair of better names and I'm not
sure what they should be
next prev parent reply other threads:[~2006-03-27 11:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 6:25 [PATCHSET] libata: add @disable_on_err to ata_set_mode(), take#2 Tejun Heo
2006-03-24 6:25 ` [PATCH 1/5] libata: check if port is disabled after internal command Tejun Heo
2006-03-24 14:40 ` Jeff Garzik
2006-03-24 6:25 ` [PATCH 4/5] libata: make ata_set_mode() responsible for failure handling Tejun Heo
2006-03-24 6:25 ` [PATCH 3/5] libata: use ata_dev_disable() in ata_bus_probe() Tejun Heo
2006-03-24 6:25 ` [PATCH 2/5] libata: implement ata_dev_disable() Tejun Heo
2006-03-24 6:25 ` [PATCH 5/5] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-24 15:04 ` Jeff Garzik
2006-03-24 15:51 ` Alan Cox
2006-03-25 0:53 ` [PATCH 1/2] libata: implement ata_dev_enabled, disabled and present() Tejun Heo
2006-03-25 3:50 ` Jeff Garzik
2006-03-25 1:14 ` [PATCH 2/2] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-25 4:03 ` Jeff Garzik
2006-03-25 5:40 ` Tejun Heo
2006-03-25 6:12 ` [PATCH 1/2] libata: implement ata_dev_enabled and disabled() Tejun Heo
2006-03-25 23:54 ` Alan Cox
2006-03-25 23:57 ` Tejun Heo
2006-03-27 11:17 ` Alan Cox [this message]
2006-03-29 6:58 ` Tejun Heo
2006-03-29 11:59 ` Alan Cox
2006-03-30 21:59 ` Jeff Garzik
2006-03-30 23:36 ` Tejun Heo
2006-03-25 6:13 ` [PATCH 2/2] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-25 23:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143458257.4970.18.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).