From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org,
Carlos.Pardo@siliconimage.com
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 08/13] sata_sil24: put port into known state before softresetting
Date: Fri, 7 Apr 2006 17:16:53 +0900 [thread overview]
Message-ID: <114439781367-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <114439781363-git-send-email-htejun@gmail.com>
Make sure the controller has no pending commands and ready for command
before issuing SRST.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/sata_sil24.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
b2c3f8df81a80fae7e9c145a5b73939799c66447
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index ccb442f..b739c23 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -475,6 +475,12 @@ static int sil24_softreset(struct ata_po
irq_enable = readl(port + PORT_IRQ_ENABLE_SET);
writel(irq_enable, port + PORT_IRQ_ENABLE_CLR);
+ /* put the port into known state */
+ if (sil24_init_port(ap)) {
+ reason ="port not ready";
+ goto err;
+ }
+
/*
* XXX: Not sure whether the following sleep is needed or not.
* The original driver had it. So....
--
1.2.4
next prev parent reply other threads:[~2006-04-07 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 8:16 [PATCHSET] sata_sil24: fixes, errata workaround and reset updates, take 2 Tejun Heo
2006-04-07 8:16 ` [PATCH 02/13] sata_sil24: typo fix Tejun Heo
2006-04-07 8:16 ` [PATCH 04/13] sata_sil24: add more constants Tejun Heo
2006-04-07 8:16 ` [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix Tejun Heo
2006-04-11 8:34 ` [PATCH 06/13 (updated)] " Tejun Heo
2006-04-11 9:11 ` Tejun Heo
2006-04-07 8:16 ` [PATCH 05/13] sata_sil24: consolidate host flags into SIL24_COMMON_FLAGS Tejun Heo
2006-04-07 8:16 ` [PATCH 07/13] sata_sil24: implement sil24_init_port() Tejun Heo
2006-04-07 8:16 ` [PATCH 01/13] libata: export ata_set_sata_spd() Tejun Heo
2006-04-07 8:16 ` Tejun Heo [this message]
2006-04-07 8:16 ` [PATCH 03/13] sata_sil24: rename PORT_IRQ_SDB_FIS to PORT_IRQ_SDB_NOTIFY Tejun Heo
2006-04-07 8:16 ` [PATCH 13/13] sata_sil24: enable 64bit Tejun Heo
2006-04-07 8:16 ` [PATCH 09/13] sata_sil24: kill 10ms sleep in softreset Tejun Heo
2006-04-07 8:16 ` [PATCH 10/13] sata_sil24: reimplement hardreset Tejun Heo
2006-04-07 8:16 ` [PATCH 11/13] sata_sil24: don't do hardreset during driver initialization Tejun Heo
2006-04-07 8:16 ` [PATCH 12/13] sata_sil24: fix on-memory structure byteorder Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2006-04-11 13:32 [PATCHSET 4/9] sata_sil24 fixes, errata workaround and reset updates, take 3 Tejun Heo
2006-04-11 13:32 ` [PATCH 08/13] sata_sil24: put port into known state before softresetting Tejun Heo
2006-04-11 17:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=114439781367-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).