From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: [PATCH 11/13] sata_sil24: don't do hardreset during driver initialization Date: Tue, 11 Apr 2006 22:32:19 +0900 Message-ID: <11447623391093-git-send-email-htejun@gmail.com> References: <11447623382439-git-send-email-htejun@gmail.com> Reply-To: Tejun Heo Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wproxy.gmail.com ([64.233.184.231]:9354 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S1750863AbWDKNc1 (ORCPT ); Tue, 11 Apr 2006 09:32:27 -0400 Received: by wproxy.gmail.com with SMTP id i11so923322wra for ; Tue, 11 Apr 2006 06:32:26 -0700 (PDT) In-Reply-To: <11447623382439-git-send-email-htejun@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com, lkosewsk@gmail.com, linux-ide@vger.kernel.org Cc: Tejun Heo There's no need to perform hardreset during driver initialization. It's already done during host reset and even if the controller is in some wacky state, we now have proper hardreset to back us up. Signed-off-by: Tejun Heo --- drivers/scsi/sata_sil24.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) 7ed6ed6896c4f03fd7253611aec7e32c36c3ad1e diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c index 8fc2d31..9d57198 100644 --- a/drivers/scsi/sata_sil24.c +++ b/drivers/scsi/sata_sil24.c @@ -1070,11 +1070,6 @@ static int sil24_init_one(struct pci_dev /* Clear port multiplier enable and resume bits */ writel(PORT_CS_PM_EN | PORT_CS_RESUME, port + PORT_CTRL_CLR); - - /* Reset itself */ - if (__sil24_reset_controller(port)) - dev_printk(KERN_ERR, &pdev->dev, - "failed to reset controller\n"); } /* Turn on interrupts */ -- 1.2.4