From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, axboe@suse.de,
albertcc@tw.ibm.com, lkosewsk@gmail.com,
linux-ide@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 09/13] sata_sil24: kill 10ms sleep in softreset
Date: Tue, 11 Apr 2006 22:32:19 +0900 [thread overview]
Message-ID: <1144762339679-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11447623382439-git-send-email-htejun@gmail.com>
Nothing, not the datasheet nor the errats, says this delay is
necessary and with the previous PORT_CS_INIT change, we know the
controller is in good state. Kill 10ms sleep.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/sata_sil24.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
3521764734fe58136495bd063c28f08e096f3b02
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
index fed47cf..933bc44 100644
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -481,12 +481,7 @@ static int sil24_softreset(struct ata_po
goto err;
}
- /*
- * XXX: Not sure whether the following sleep is needed or not.
- * The original driver had it. So....
- */
- msleep(10);
-
+ /* do SRST */
prb->ctrl = PRB_CTRL_SRST;
prb->fis[1] = 0; /* no PM yet */
--
1.2.4
next prev parent reply other threads:[~2006-04-11 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 13:32 [PATCHSET 4/9] sata_sil24 fixes, errata workaround and reset updates, take 3 Tejun Heo
2006-04-11 13:32 ` [PATCH 01/13] libata: export ata_set_sata_spd() Tejun Heo
2006-04-11 17:32 ` Jeff Garzik
2006-04-11 13:32 ` [PATCH 04/13] sata_sil24: add more constants Tejun Heo
2006-04-11 13:32 ` [PATCH 03/13] sata_sil24: rename PORT_IRQ_SDB_FIS to PORT_IRQ_SDB_NOTIFY Tejun Heo
2006-04-11 13:32 ` [PATCH 02/13] sata_sil24: typo fix Tejun Heo
2006-04-11 13:32 ` [PATCH 05/13] sata_sil24: consolidate host flags into SIL24_COMMON_FLAGS Tejun Heo
2006-04-11 13:32 ` [PATCH 07/13] sata_sil24: implement sil24_init_port() Tejun Heo
2006-04-11 13:32 ` [PATCH 13/13] sata_sil24: enable 64bit Tejun Heo
2006-04-11 13:32 ` [PATCH 08/13] sata_sil24: put port into known state before softresetting Tejun Heo
2006-04-11 17:29 ` Jeff Garzik
2006-04-11 13:32 ` [PATCH 12/13] sata_sil24: fix on-memory structure byteorder Tejun Heo
2006-04-11 13:32 ` [PATCH 10/13] sata_sil24: reimplement hardreset Tejun Heo
2006-04-11 13:32 ` [PATCH 11/13] sata_sil24: don't do hardreset during driver initialization Tejun Heo
2006-04-11 13:32 ` [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix Tejun Heo
2006-04-11 17:27 ` Jeff Garzik
2006-04-12 1:13 ` Tejun Heo
2006-04-11 13:32 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-07 8:16 [PATCHSET] sata_sil24: fixes, errata workaround and reset updates, take 2 Tejun Heo
2006-04-07 8:16 ` [PATCH 09/13] sata_sil24: kill 10ms sleep in softreset Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144762339679-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).