From mboxrd@z Thu Jan 1 00:00:00 1970 From: "zhao, forrest" Subject: Re: [PATCHSET 9/9] add hotplug support Date: Thu, 13 Apr 2006 15:53:58 +0800 Message-ID: <1144914838.19687.18.camel@localhost.localdomain> References: <1144764846705-git-send-email-htejun@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:14429 "EHLO orsmga101-1.jf.intel.com") by vger.kernel.org with ESMTP id S964827AbWDMIEJ (ORCPT ); Thu, 13 Apr 2006 04:04:09 -0400 In-Reply-To: <1144764846705-git-send-email-htejun@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com, lkosewsk@gmail.com, linux-ide@vger.kernel.org On Tue, 2006-04-11 at 23:14 +0900, Tejun Heo wrote: > Warm unplug/plug comes at almost no cost for LLDDs implementing new EH > - adding a call to ata_eh_hotplug() at the end of ->error_handler is > enough (even this is unnecessary if it's using bmdma error_handler). > e.g. ata_piix isn't changed by hotplug patchsets at all but still > supports warm plugging (even PATA warm plugging works although it's > electronically unsafe). > > To support full hot unplug/plug, all a LLDD has to do are enabling PHY > status changed interrupt and, when PHY RDY status changes, call > ata_schedule_probe() and schedule EH. ahci, sata_sil and sata_sil24 > are converted this way and hotplugging works perfectly for those > drivers. > In order to make ata_eh_hotplug() called, LLDD have to schedule EH in its interrupt handler(i.e. invoke scsi_eh_schedule_host() directly or indirectly), but I didn't find such code in your patch set. Did I miss anything? Thanks, Forrest