From: "zhao, forrest" <forrest.zhao@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fix a logic error in ahci_init_one()
Date: Fri, 14 Apr 2006 17:12:58 +0800 [thread overview]
Message-ID: <1145005978.24774.14.camel@localhost.localdomain> (raw)
In-Reply-To: <443F6189.7050204@pobox.com>
On Fri, 2006-04-14 at 04:47 -0400, Jeff Garzik wrote:
> zhao, forrest wrote:
> > Fix an bug in error handling, also variable
> > pci_dev_busy has no use, remove it.
> >
> > Signed-off-by: Zhao Forrest <forrest.zhao@intel.com>
>
> What logic error do you see?
>
> pci_dev_busy has a clear use, as illustrated by the code: if the PCI
> regions are reserved by another device, the device is in use, therefore
> we should avoid killing the device with pci_disable_device().
>
> Jeff
Oh, one PCI device can be probed by multiple drivers. It's first
time for me to meet such case.
Please forgive my ignorance.
Forrest
prev parent reply other threads:[~2006-04-14 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 7:31 [PATCH] Fix a logic error in ahci_init_one() zhao, forrest
2006-04-14 8:47 ` Jeff Garzik
2006-04-14 9:12 ` zhao, forrest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145005978.24774.14.camel@localhost.localdomain \
--to=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox