From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 08/11] sata_sil: convert to new EH Date: Thu, 11 May 2006 17:12:53 +0100 Message-ID: <1147363974.26130.56.camel@localhost.localdomain> References: <11473536881889-git-send-email-htejun@gmail.com> <1147357322.26130.17.camel@localhost.localdomain> <44634CB6.80804@gmail.com> <1147362385.26130.42.camel@localhost.localdomain> <44635C29.6080903@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:24475 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1030291AbWEKQCs (ORCPT ); Thu, 11 May 2006 12:02:48 -0400 In-Reply-To: <44635C29.6080903@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: jgarzik@pobox.com, axboe@suse.de, albertcc@tw.ibm.com, forrest.zhao@intel.com, efalk@google.com, linux-ide@vger.kernel.org On Gwe, 2006-05-12 at 00:45 +0900, Tejun Heo wrote: > a spurious interrupt or HSM violation. But, it sounds like it could > result in screaming IRQ for controllers without IRQ pending bit. Could > it? If so, maybe unconditional irq clearing in ata_interrupt() should > be resurrected to handle such conditions. Not sure how the sil24 handles it but the PATA chips seem (its not well documented) to drop any pending interrupt once it is masked, thus you would take the interrupt once (or maybe 2 or 3 times in weird obscure corner cases on a pentium II SMP box) and then no more. Alan