From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 02/11] libata-eh: implement ata_ering
Date: Mon, 15 May 2006 15:50:57 +0100
Message-ID: <1147704657.26686.49.camel@localhost.localdomain>
References: <11473536871340-git-send-email-htejun@gmail.com>
	 <44665AAB.7000806@pobox.com> <44666D98.1000503@gmail.com>
	 <44668249.9000004@pobox.com> <446685D1.4030607@gmail.com>
	 <446688C8.6020001@pobox.com>
	 <1147700193.26686.7.camel@localhost.localdomain>
	 <44688991.8010407@gmail.com>  <44688F69.8030002@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from [81.2.110.250] ([81.2.110.250]:17606 "EHLO lxorguk.ukuu.org.uk")
	by vger.kernel.org with ESMTP id S964949AbWEOOin (ORCPT
	<rfc822;linux-ide@vger.kernel.org>); Mon, 15 May 2006 10:38:43 -0400
In-Reply-To: <44688F69.8030002@gmail.com>
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, axboe@suse.de, albertcc@tw.ibm.com, forrest.zhao@intel.com, efalk@google.com, linux-ide@vger.kernel.org

On Llu, 2006-05-15 at 23:25 +0900, Tejun Heo wrote:
> I was too quick to response.  ering keeps track of timestamps of each
> error and the criteria for speeding down is something like "3 class 1
> errors during last 15mins", so bitmaps doesn't cut it.

Sounds like it does


	log_class_1_error(dev)
	{
		if((dev->class1 & 3) < 3) {
			dev->class1++;
			dev->class1sum++;
		} else {
			/* 3 this minute alone */
			it_happened_now_case();
		}
	}

	class_1_each_minute(dev)
	{
		dev->class1sum -= (dev->class1 >> 30);
		dev->class1 <<= 2;
	}