From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide_dma_speed() fixes
Date: Mon, 15 May 2006 16:27:04 +0100 [thread overview]
Message-ID: <1147706824.26686.66.camel@localhost.localdomain> (raw)
In-Reply-To: <20060515080053.296c4c55.akpm@osdl.org>
On Llu, 2006-05-15 at 08:00 -0700, Andrew Morton wrote:
>
> /* Capable of UltraDMA modes? */
> - if (id->field_valid & 4)
> - ultra_mask = id->dma_ultra & hwif->ultra_mask;
> - else
> + ultra_mask = id->dma_ultra & hwif->ultra_mask;
> +
> + if (!(id->field_valid & 4))
> mode = 0; /* fallback to MW/SW DMA if no UltraDMA */
>
Looks fine to me, id-> is always the full 512 bytes of data so its safe
to do that.
prev parent reply other threads:[~2006-05-15 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-12 2:36 [PATCH] ide_dma_speed() fixes Sergei Shtylyov
2006-05-14 12:05 ` Andrew Morton
2006-05-15 13:44 ` Sergei Shtylyov
2006-05-15 14:08 ` Alan Cox
2006-05-15 15:00 ` Andrew Morton
2006-05-15 15:27 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147706824.26686.66.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).