From: "zhao, forrest" <forrest.zhao@intel.com>
To: Jens Axboe <axboe@suse.de>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: ata_piix resume from S3 on T43P failed
Date: Tue, 16 May 2006 11:56:34 +0800 [thread overview]
Message-ID: <1147751795.7273.80.camel@forrest26.sh.intel.com> (raw)
In-Reply-To: <20060512101713.GN4157@suse.de>
On Fri, 2006-05-12 at 12:17 +0200, Jens Axboe wrote:
> The key is the 0xef timeout, then the device is offlined and you see a
> lot of io errors due to that.
>
> Try this:
>
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index bd14720..f120839 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -4288,6 +4288,7 @@ int ata_device_resume(struct ata_port *a
> {
> if (ap->flags & ATA_FLAG_SUSPENDED) {
> ap->flags &= ~ATA_FLAG_SUSPENDED;
> + mdelay(2000);
> ata_set_mode(ap);
> }
> if (!ata_dev_present(dev))
>
Jens,
Yes! The patch works. But I'm wondering why ata_piix driver in kernel
2.6.16-rc6 works without mdelay(2000); in ata_device_resume()?
Thanks,
Forrest
next prev parent reply other threads:[~2006-05-16 4:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 8:05 ata_piix resume from S3 on T43P failed zhao, forrest
2006-05-11 8:31 ` Tejun Heo
2006-05-11 8:35 ` Tejun Heo
2006-05-11 9:46 ` zhao, forrest
2006-05-11 10:39 ` Tejun Heo
2006-05-12 5:02 ` zhao, forrest
2006-05-11 10:55 ` Jens Axboe
2006-05-12 5:51 ` zhao, forrest
2006-05-12 10:17 ` Jens Axboe
2006-05-12 10:56 ` Tejun Heo
2006-05-16 3:56 ` zhao, forrest [this message]
2006-05-17 11:03 ` Jens Axboe
2006-05-17 12:56 ` Jeff Garzik
2006-05-17 13:02 ` Jens Axboe
2006-05-22 7:32 ` Jeff Garzik
2006-05-13 4:19 ` Jeff Garzik
2006-05-16 1:58 ` zhao, forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147751795.7273.80.camel@forrest26.sh.intel.com \
--to=forrest.zhao@intel.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).