From: "zhao, forrest" <forrest.zhao@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mark Lord <liml@rtr.ca>, linux-ide@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH alt4 v3] libata resume fixes
Date: Mon, 29 May 2006 11:53:13 +0800 [thread overview]
Message-ID: <1148874794.2310.21.camel@forrest26.sh.intel.com> (raw)
In-Reply-To: <4478C2C9.3030703@garzik.org>
On Sat, 2006-05-27 at 17:21 -0400, Jeff Garzik wrote:
> o_simple_cmd: ata command failed: 4
>
> 0xE1 is IDLE IMMEDIATE, so it looks like it is making progress.
>
> This makes me realize that ata_bus_probe() won't get the job done
> alone,
> we must do:
>
> * host init
> * phy init
> * idle immediate
> * the rest of bus probe
>
> Good, good data points here...
Jeff,
This observation is very valuable. I'll write the patch for this
together with the AHCI suspend/resume support for 2.6.1[8/9] soon.
BTW. Have we achieved consensus that the bus resume operation should be
done in [s/p]ata_pci_device_resume() in 2.6.1[8/9]?
Thanks,
Forrest
next prev parent reply other threads:[~2006-05-29 4:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 19:58 [PATCH alt4] libata resume fixes Jeff Garzik
2006-05-27 20:10 ` [PATCH alt4 v2] " Jeff Garzik
2006-05-27 20:14 ` Jeff Garzik
2006-05-27 20:30 ` Mark Lord
[not found] ` <4478B611.2030201@rtr.ca>
2006-05-27 20:32 ` Jeff Garzik
2006-05-27 20:41 ` Mark Lord
2006-05-27 20:56 ` Jeff Garzik
2006-05-27 21:00 ` Mark Lord
2006-05-27 21:06 ` Jeff Garzik
2006-05-27 21:09 ` Mark Lord
2006-05-27 21:14 ` Jeff Garzik
2006-05-27 20:13 ` [PATCH alt4] " Mark Lord
2006-05-27 20:52 ` [PATCH alt4 v3] " Jeff Garzik
2006-05-27 20:56 ` Mark Lord
2006-05-27 21:11 ` Jeff Garzik
2006-05-27 21:15 ` Mark Lord
2006-05-27 21:25 ` Jeff Garzik
2006-05-27 21:12 ` Mark Lord
2006-05-27 21:21 ` Jeff Garzik
2006-05-29 3:53 ` zhao, forrest [this message]
2006-05-29 5:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148874794.2310.21.camel@forrest26.sh.intel.com \
--to=forrest.zhao@intel.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).