From: "zhao, forrest" <forrest.zhao@intel.com>
To: Hannes Reinecke <hare@suse.de>
Cc: jeff@garzik.org, axboe@suse.de, htejun@gmail.com,
jeremy@goop.org, lkml@rtr.ca, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/6] The definition of ahci_port_standby() and ahci_port_spinup()
Date: Fri, 02 Jun 2006 17:01:53 +0800 [thread overview]
Message-ID: <1149238913.29552.7.camel@forrest26.sh.intel.com> (raw)
In-Reply-To: <447FF381.4060707@suse.de>
On Fri, 2006-06-02 at 10:14 +0200, Hannes Reinecke wrote:
> Did you actually test with staggered-spinup and/or cold-presence
> detection? I just added them per spec but never got a chance to test
> them here.
We have no mobile platform in our lab, which support staggered-spinup or
cold presence detection. I would test it when the newest chipset is
available.
> And: it might be an idea to rename the HOST_CAP bits to be consistent
> with those printed during initialisation. It's bad enough as it is (ie
> the spec uses different abbrevs than the implementation), but we should
> try to be consistent within the implementation.
> I would rename them to HOST_CAP_STAG and HOST_CAP_SLUM.
Agree. When reading code, I need to translate the MACRO into the abbrevs
in spec to understand the meaning.
> Add slumber mode: libata-core used to issue a port reset with an
> implicit SLUMBER/PARTIAL mode disable. So after a reset we might not be
> able to put the device into SLUMBER mode even if supported.
> What was the reasoning for this?
I have the same question. Maybe the original author of libata-core.c can
help answer it.
next prev parent reply other threads:[~2006-06-02 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 7:45 [PATCH 3/6] The definition of ahci_port_standby() and ahci_port_spinup() zhao, forrest
2006-06-02 8:14 ` Hannes Reinecke
2006-06-02 9:01 ` zhao, forrest [this message]
2006-06-03 13:23 ` Tejun Heo
2006-06-03 19:16 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-06-06 10:17 zhao, forrest
2006-06-29 8:19 zhao, forrest
2006-07-10 3:35 zhao, forrest
2006-07-11 6:38 zhao, forrest
2006-07-13 5:38 zhao, forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149238913.29552.7.camel@forrest26.sh.intel.com \
--to=forrest.zhao@intel.com \
--cc=axboe@suse.de \
--cc=hare@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jeremy@goop.org \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).