linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "zhao, forrest" <forrest.zhao@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command(v5)
Date: Mon, 12 Jun 2006 12:23:24 +0800	[thread overview]
Message-ID: <1150086204.5721.37.camel@forrest26.sh.intel.com> (raw)
In-Reply-To: <448CEBCE.9080206@garzik.org>

On Mon, 2006-06-12 at 00:21 -0400, Jeff Garzik wrote:
> Jeff Garzik wrote:
> > zhao, forrest wrote:
> >> This patch makes libata "Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE
> >> command" and clean the things up(e.g. revalidate and rescan).
> >>
> >> Signed-off-by: Forrest Zhao <forrest.zhao@intel.com>
> > 
> > applied
> 
> Um... please make sure all your patches build!
> 
> I had to apply the attached patch to get it to work.
> 
> 	Jeff
> 
> 
> 
> Plain text document attachment (patch)
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 39e6b77..61eea57 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -522,6 +522,7 @@ struct ata_port {
>  
>  	struct work_struct	port_task;
>  	struct work_struct	hotplug_task;
> +	struct work_struct	scsi_rescan_task;
>  
>  	unsigned int		hsm_task_state;

Oh, sorry for that. I had tested the patch before sending it out. 
But don't know why this line is missing. Do I need to re-send the whole
patch?

BTW. the disk of my develop machine for SATA was corrupted 10 minutes
ago after I applied the AHCI suspend/resume patch against #upstream, I
had to recover it painfully. Haven't expected that it can cause such bad
damage :(

Forrest

  reply	other threads:[~2006-06-12  4:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12  4:01 [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command(v5) zhao, forrest
2006-06-12  4:18 ` Jeff Garzik
2006-06-12  4:21   ` Jeff Garzik
2006-06-12  4:23     ` zhao, forrest [this message]
2006-06-12  4:43       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150086204.5721.37.camel@forrest26.sh.intel.com \
    --to=forrest.zhao@intel.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).