* PATCH: SC1200 debug printk
@ 2006-06-26 13:51 Alan Cox
2006-06-26 17:04 ` Valdis.Kletnieks
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2006-06-26 13:51 UTC (permalink / raw)
To: akpm, linux-ide, linux-kernel
Kill a pair of long escaped debug printk calls
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.17/drivers/ide/pci/sc1200.c linux-2.6.17/drivers/ide/pci/sc1200.c
--- linux.vanilla-2.6.17/drivers/ide/pci/sc1200.c 2006-06-19 17:17:24.000000000 +0100
+++ linux-2.6.17/drivers/ide/pci/sc1200.c 2006-06-26 13:27:45.671877280 +0100
@@ -395,7 +395,6 @@
{
ide_hwif_t *hwif = NULL;
-printk("SC1200: resume\n");
pci_set_power_state(dev, PCI_D0); // bring chip back from sleep state
dev->current_state = PM_EVENT_ON;
pci_enable_device(dev);
@@ -405,7 +404,6 @@
while ((hwif = lookup_pci_dev(hwif, dev)) != NULL) {
unsigned int basereg, r, d, format;
sc1200_saved_state_t *ss = (sc1200_saved_state_t *)hwif->config_data;
-printk("%s: SC1200: resume\n", hwif->name);
//
// Restore timing registers: this may be unnecessary if BIOS also does it
@@ -493,7 +491,7 @@
}
static struct pci_device_id sc1200_pci_tbl[] = {
- { PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_SCx200_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+ { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_SCx200_IDE), 0},
{ 0, },
};
MODULE_DEVICE_TABLE(pci, sc1200_pci_tbl);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: SC1200 debug printk
2006-06-26 13:51 PATCH: SC1200 debug printk Alan Cox
@ 2006-06-26 17:04 ` Valdis.Kletnieks
2006-06-26 18:12 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Valdis.Kletnieks @ 2006-06-26 17:04 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Mon, 26 Jun 2006 14:51:45 BST, Alan Cox said:
> Kill a pair of long escaped debug printk calls
>
> Signed-off-by: Alan Cox <alan@redhat.com>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.17/drivers/ide/pci/sc1200.c linux-2.6.17/drivers/ide/pci/sc1200.c
> --- linux.vanilla-2.6.17/drivers/ide/pci/sc1200.c 2006-06-19 17:17:24.000000000 +0100
> +++ linux-2.6.17/drivers/ide/pci/sc1200.c 2006-06-26 13:27:45.671877280 +0100
Hmm...
> @@ -493,7 +491,7 @@
> }
>
> static struct pci_device_id sc1200_pci_tbl[] = {
> - { PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_SCx200_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> + { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_SCx200_IDE), 0},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, sc1200_pci_tbl);
Escape of an unrelated change to the same file?
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: SC1200 debug printk
2006-06-26 17:04 ` Valdis.Kletnieks
@ 2006-06-26 18:12 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2006-06-26 18:12 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: akpm, linux-ide, linux-kernel
Ar Llu, 2006-06-26 am 13:04 -0400, ysgrifennodd Valdis.Kletnieks@vt.edu:
> Escape of an unrelated change to the same file?
Passing hoovering.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-26 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-26 13:51 PATCH: SC1200 debug printk Alan Cox
2006-06-26 17:04 ` Valdis.Kletnieks
2006-06-26 18:12 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).