From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org, akpm@osdl.org
Subject: PATCH: Fixes for PIIX driver
Date: Mon, 10 Jul 2006 17:54:29 +0100 [thread overview]
Message-ID: <1152550469.27368.150.camel@localhost.localdomain> (raw)
A couple of cases were mishandled by the PIIX driver because of wrong
entries in tables. This caused some ICH chips to select UDMA33 not the
correct higher UDMA speed. It could also cause the original ICH to
select a mode the controller didn't support and then fail on boot.
Signed-off-by: Alan Cox <alan@redhat.com>
---
drivers/scsi/ata_piix.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
88d42653b87dcf9359c7a7874ce21031b71df117
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c
index 3eb2c86..0f21940 100644
--- a/drivers/scsi/ata_piix.c
+++ b/drivers/scsi/ata_piix.c
@@ -93,7 +93,7 @@
#include <linux/libata.h>
#define DRV_NAME "ata_piix"
-#define DRV_VERSION "2.00ac5"
+#define DRV_VERSION "2.00ac6"
enum {
PIIX_IOCFG = 0x54, /* IDE I/O configuration register */
@@ -412,7 +412,7 @@ static struct ata_port_info piix_port_in
.host_flags = ATA_FLAG_SRST | ATA_FLAG_SLAVE_POSS,
.pio_mask = 0x1f, /* pio 0-4 */
.mwdma_mask = 0x06, /* Check: maybe 0x07 */
- .udma_mask = ATA_UDMA6, /* UDMA133 */
+ .udma_mask = ATA_UDMA2, /* UDMA33 */
.port_ops = &ich_pata_ops,
},
/* ich_pata_66: 2 ICH controllers up to 66MHz */
@@ -431,8 +431,8 @@ static struct ata_port_info piix_port_in
.host_flags = ATA_FLAG_SRST | ATA_FLAG_SLAVE_POSS | PIIX_FLAG_CHECKINTR,
.pio_mask = 0x1f, /* pio0-4 */
.mwdma_mask = 0x06, /* mwdma1-2 */
- .udma_mask = 0x3f, /* udma0-5 */
- .port_ops = &piix_pata_ops,
+ .udma_mask = ATA_UDMA5, /* udma0-5 */
+ .port_ops = &ich_pata_ops,
},
/* ich_pata_133: 4 ICH with full UDMA6 */
--
1.2.GIT
next reply other threads:[~2006-07-10 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 16:54 Alan Cox [this message]
2006-07-11 14:37 ` PATCH: Fixes for PIIX driver Brad Campbell
2006-07-19 18:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152550469.27368.150.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).