From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.ukjgarzik@pobox.com,
akpm@osdl.org, davej@redhat.com, linux-ide@vger.kernel.org
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>
Subject: [PATCH 03/11] [libata] manually inline ata_host_remove()
Date: Wed, 2 Aug 2006 05:11:49 +0900 [thread overview]
Message-ID: <1154463109539-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11544631081793-git-send-email-htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-core.c | 31 ++++++-------------------------
1 files changed, 6 insertions(+), 25 deletions(-)
2807702eafe33dd1783fd39c7137376082521736
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 1cc12d4..4e06edc 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -5185,28 +5185,6 @@ void ata_host_stop (struct ata_host_set
iounmap(host_set->mmio_base);
}
-
-/**
- * ata_host_remove - Unregister SCSI host structure with upper layers
- * @ap: Port to unregister
- * @do_unregister: 1 if we fully unregister, 0 to just stop the port
- *
- * LOCKING:
- * Inherited from caller.
- */
-
-static void ata_host_remove(struct ata_port *ap, unsigned int do_unregister)
-{
- struct Scsi_Host *sh = ap->host;
-
- DPRINTK("ENTER\n");
-
- if (do_unregister)
- scsi_remove_host(sh);
-
- ap->ops->port_stop(ap);
-}
-
/**
* ata_dev_init - Initialize an ata_device structure
* @dev: Device structure to initialize
@@ -5532,8 +5510,11 @@ int ata_device_add(const struct ata_prob
err_out:
for (i = 0; i < count; i++) {
- ata_host_remove(host_set->ports[i], 1);
- scsi_host_put(host_set->ports[i]->host);
+ struct ata_port *ap = host_set->ports[i];
+
+ scsi_remove_host(ap->host);
+ ap->ops->port_stop(ap);
+ scsi_host_put(ap->host);
}
err_free_ret:
kfree(host_set);
@@ -5662,7 +5643,7 @@ int ata_scsi_release(struct Scsi_Host *h
DPRINTK("ENTER\n");
ap->ops->port_disable(ap);
- ata_host_remove(ap, 0);
+ ap->ops->port_stop(ap);
DPRINTK("EXIT\n");
return 1;
--
1.3.2
next prev parent reply other threads:[~2006-08-01 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 20:11 [PATCHSET] libata: improve initialization and legacy handling Tejun Heo
2006-08-01 20:11 ` [PATCH 02/11] [libata] some function renaming Tejun Heo
2006-08-01 20:11 ` [PATCH 05/11] libata: fix ata_device_add() error path Tejun Heo
2006-08-01 20:11 ` [PATCH 04/11] [libata] Kill 'count' var in ata_device_add() Tejun Heo
2006-08-01 20:11 ` Tejun Heo [this message]
2006-08-01 20:11 ` [PATCH 01/11] ata_piix: fix host_set private_data intialization Tejun Heo
2006-08-01 20:11 ` [PATCH 07/11] libata: fix several bugs in reworked legacy handling Tejun Heo
2006-08-01 20:11 ` [PATCH 08/11] libata: implement dummy port Tejun Heo
2006-08-01 20:11 ` [PATCH 06/11] libata: rework legacy handling to remove much of the cruft Tejun Heo
2006-08-01 20:11 ` [PATCH 10/11] libata: replace ap->hard_port_no with ap->port_no Tejun Heo
2006-08-01 20:11 ` [PATCH 11/11] libata: kill unused hard_port_no and legacy_mode Tejun Heo
2006-08-01 20:11 ` [PATCH 09/11] libata: use dummy port for stolen legacy ports Tejun Heo
2006-08-01 21:57 ` [PATCHSET] libata: improve initialization and legacy handling Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154463109539-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.ukjgarzik \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).