linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Ammermüller" <tenco@gmx.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [sata_sil] kernel 2.6.17(-mm2) test - timeout issue
Date: Mon, 14 Aug 2006 12:12:00 +0200	[thread overview]
Message-ID: <1155550320.6423.2.camel@localhost> (raw)
In-Reply-To: <44D61004.3070109@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

Am Montag, den 07.08.2006, 00:51 +0900 schrieb Tejun Heo: 
> I'm not sure why the previous patch didn't kick in.  The condition 
> should have been caught and EH_HARDRESET requested.  Can you please 
> double check the patched kernel is running?  You can put a little 
> printk() after the freeze: label in sil_interrupt() to be sure.  That's 
> the only place where sata_sil freezes the port except for timing out.

Sorry, i couldn't find a "freeze" label in sil_interrupt(). There's one
in sil_host_intr(), but appending 'printk("THIS VERSION RUNS MODIFIED
sata_sil!");' there, doesn't have any effect (it doesn't get printed
out). That's the only freeze label i found in sata_sil.c. My original
drivers/scsi/sata_sil.c was version 2.6.18-rc1.

'strings /lib/modules/2.6.18-rc1/kernel/drivers/scsi/sata_sil.ko'
doesn't give any unexpected results:

----------------------
[...]
<7>%s %s: version 2.0
<3>ata%u: XXX: qc=%p ctl=%x
<3>ata%u: XXX: HSM=%d
<6>ata%u.%02u: applying Seagate errata fix (mod15write workaround)
<6>ata%u.%02u: applying Maxtor errata fix %s
<4>%s %s: cache line size not set.  Driver may not function
<6>%s %s: Applying R_ERR on DMA activate FIS errata fix
<3>ata%u: XXX: SATA_IRQ serror=%x
<3>ata%u: XXX: BUSY status=%x
THIS VERSION RUNS MODIFIED sata_sil!
[...]
------------------------

The kernel was built with Debian's make-kpkg (make-kpkg --initrd
kernel_image). Output is still the same.

- Martin

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

      reply	other threads:[~2006-08-14 10:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-24 20:50 [sata_sil] kernel 2.6.17(-mm2) test - timeout issue Martin Ammermüller
2006-06-25  3:06 ` Tejun Heo
2006-07-24  8:21   ` Martin Ammermüller
2006-07-30 20:22     ` Tejun Heo
2006-08-05 13:36       ` Martin Ammermüller
2006-08-06 15:51         ` Tejun Heo
2006-08-14 10:12           ` Martin Ammermüller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155550320.6423.2.camel@localhost \
    --to=tenco@gmx.de \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).