From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, Joe Jin <lkmaillist@gmail.com>
Subject: Re: [PATCH] libata: handle 0xff status properly
Date: Wed, 11 Oct 2006 17:16:28 +0100 [thread overview]
Message-ID: <1160583388.16513.27.camel@localhost.localdomain> (raw)
In-Reply-To: <20061009093215.GF10832@htj.dyndns.org>
Ar Llu, 2006-10-09 am 18:32 +0900, ysgrifennodd Tejun Heo:
> libata waits for !BSY even when the status register reports 0xff.
> This causes long boot delays when D8 isn't pulled down properly. This
> patch does the followings.
>
> * don't wait if status register is 0xff in all wait functions
>
> * make ata_busy_sleep() return 0 on success and -errno on failure.
> -ENODEV is returned on 0xff status and -EBUSY on other failures.
>
> * make ata_bus_softreset() succeed on 0xff status. 0xff status is not
> reset failure. It indicates no device. This removes unnecessary
> retries on such ports. Note that the code change assumes unoccupied
> port reporting 0xff status does not produce valid device signature.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Joe Jin <lkmaillist@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2006-10-11 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 9:32 [PATCH] libata: handle 0xff status properly Tejun Heo
2006-10-11 16:16 ` Alan Cox [this message]
2006-11-01 4:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160583388.16513.27.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkmaillist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).