linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk,
	linux-ide@vger.kernel.org, htejun@gmail.com
Subject: [PATCHSET #upstream] libata: implement presence detection using polling IDENTIFY for ata_piix, take #2
Date: Fri, 10 Nov 2006 18:08:09 +0900	[thread overview]
Message-ID: <11631496893280-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: 

Hello, all.

This is the second take of polling-IDENTIFY patchset.  Other than
rebased on the current upstream, nothing has changed since the last
take[L].

Some SATA and many PATA controllers don't have reliable way to detect
device presence and some controllers report master device's signature
as slave's if slave isn't present.  This sometimes results in failure
to detect devices and at other times phantom devices which cause
considerable delay during boot.

This patchset implements device detection via polling IDENTIFY, which
is used by IDE and was used by old libata.  When no device present,
!BSY && !DRQ status is seen while trying to read the IDENTIFY block.
If a LLD specifies ATA_FLAG_DETECT_POLLING, IDENTIFY command is issued
using polling PIO and the HSM marks AC_ERR_NODEV_HINT if !BSY && !DRQ
is met.  Then the probing logic marks the device non-existent silently
and continues probing.

ata_piix is having a lot of problem involving missing and/or phantom
devices and converted to use polling IDENTIFY by this patchset.

This patchset contains 6 patches.

#01-02	: prep for ATA_FLAG_DETECT_POLLING implementation
#03	: implement ATA_DETECT_POLLING
#04	: apply ATA_DETECT_POLLING to ata_piix
#05	: kill unnecessary parts from ata_piix

This patchset is against

  upstream (cfd15b0011498986ef14b6c53f5eaba89d2171f3)

Thanks.

--
tejun

[L] http://thread.gmane.org/gmane.linux.ide/13284/focus=13284



             reply	other threads:[~2006-11-10  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-10  9:08 Tejun Heo [this message]
2006-11-10  9:08 ` [PATCH 4/5] ata_piix: apply device detection via polling IDENTIFY Tejun Heo
2006-11-10  9:08 ` [PATCH 2/5] libata: convert @post_reset to @flags in ata_dev_read_id() Tejun Heo
2006-11-10  9:08 ` [PATCH 1/5] ata_piix: clean up port flags Tejun Heo
2006-11-14 19:23   ` Jeff Garzik
2006-11-10  9:08 ` [PATCH 5/5] ata_piix: strip now unneded MAP related stuff Tejun Heo
2006-11-10  9:08 ` [PATCH 3/5] libata: implement presence detection via polling IDENTIFY Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11631496893280-git-send-email-htejun@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).