From: Tejun Heo <htejun@gmail.com>
To: jeff@garzik.org, alan@lxorguk.ukuu.org.uk, ric@emc.com,
edmudama@gmail.com, linux-ide@vger.kernel.org, htejun@gmail.com
Subject: asdf
Date: Fri, 2 Feb 2007 16:22:30 +0900 [thread overview]
Message-ID: <11704009502014-git-send-email-htejun@gmail.com> (raw)
In-Reply-To:
Hello,
The current EH speed down code is more of a feature demonstration and
goes through rdiculously many meaningless steps when condition is met.
This patchset tries to put some intelligence into speed down sequence.
The goal is to achieve reasonable number of speed down steps
reasonably spaced from one another and consider NCQ, cable type and
the current protocol when determining speed down steps, while not
bloating the code too much with nitty gritty details.
Roughly, the rules are...
1. If NCQ and protocol/timeout/unknown dev errors occur, turn off NCQ
2. If excessive transfer errors occur, speed down within the current
transfer mode (UDMA/MWDMA/PIO). If UDMA, it's first adjusted down
a step, if error conditions persist, 40c limit is applied. Speed
down is done only twice.
3. If PATA && used up all DMA speed down steps && a LOT of
transmission/unknown errors occur, switch to PIO. So, we never
automatically step down to PIO on SATA. This is intended. Some
SATA hdd even seems to have problem with PIO data transfer
commands.
The last patch makes ahci report HSM violation error on spurious
completion of NCQ commands, thus causing NCQ off after several such
incidents. These drives should be blacklisted for DMA eventually.
This patchset is against...
upstream (eb0e63cca36a3389f0ccab4584f6d479b983fad5)
+ [1] pata_platform-fix-devres-conversion
+ [2] libata-convert-to-iomap
Ric, I guess this resolves the to-do item from you which has been
sitting in my mailbox for way too long. What do you think about the
rules?
Thanks.
--
tejun
[1] http://article.gmane.org/gmane.linux.kernel/488509
[2] hmm.. can't find it any archive. Might have been ignored due to
size. Jeff, did you receive it?
next reply other threads:[~2007-02-02 7:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 7:22 Tejun Heo [this message]
2007-02-02 7:22 ` [PATCH 2/5] libata: improve probe failure handling Tejun Heo
2007-02-02 7:22 ` [PATCH 1/5] libata: improve ata_down_xfermask_limit() Tejun Heo
2007-02-20 15:46 ` Jeff Garzik
2007-02-02 7:22 ` [PATCH 4/5] libata: kill ATA_DNXFER_ANY Tejun Heo
2007-02-02 7:22 ` [PATCH 3/5] libata: put some intelligence into EH speed down sequence Tejun Heo
2007-02-02 7:22 ` [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation Tejun Heo
2007-02-20 15:46 ` Jeff Garzik
2007-02-21 7:34 ` [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation (regenerated) Tejun Heo
2007-02-23 10:37 ` Jeff Garzik
2007-02-02 7:24 ` Subject is [PATCH,RESEND] libata: put some intelligence into speed down sequence Tejun Heo
2007-02-02 16:59 ` asdf Ric Wheeler
2007-02-03 4:07 ` asdf Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11704009502014-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=edmudama@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=ric@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).