linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: jeff@garzik.org
Cc: htejun@gmail.com, linux-ide@vger.kernel.org, jeremy@sgi.com, liml@rtr.ca
Subject: RE: sata_vsc with iq3124h regression in 2.6.20
Date: Fri, 09 Feb 2007 16:26:49 -0700	[thread overview]
Message-ID: <1171063609.29541.6.camel@dwillia2-linux.ch.intel.com> (raw)

> As I recall, the 31244 and VSC-7174 always send an interrupt, so the
> driver should account for this.  I thought we had code already in the
> driver to handle this, but perhaps recent changes stomped that.
> 
> It would be good to standardize the way we handle these sorts of
> controllers, because (I think) Mark Lord has the same problem on
> sata_qstor (or pdc_adma?).
> 
> 	Jeff

The error interrupt handling code is still in there and is working.  The
following patch works for me.

---
sata_vsc: handle unexpected interrupts when executing a polled IDENTIFY

From: Dan Williams <dan.j.williams@intel.com>

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

 drivers/ata/sata_vsc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/sata_vsc.c b/drivers/ata/sata_vsc.c
index 0fa1b89..7425d62 100644
--- a/drivers/ata/sata_vsc.c
+++ b/drivers/ata/sata_vsc.c
@@ -258,7 +258,9 @@ static irqreturn_t vsc_sata_interrupt (int irq, void *dev_instance)
 					/* Clear interrupt status */
 					ata_chk_status(ap);
 					handled++;
-				}
+				} else if (qc->tf.command == ATA_CMD_ID_ATA)
+					/* 31244 interrupts on polled IDENTIFY commands */
+					ata_chk_status(ap);
 			}
 		}
 	}

             reply	other threads:[~2007-02-09 23:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 23:26 Dan Williams [this message]
2007-02-12  3:19 ` sata_vsc with iq3124h regression in 2.6.20 Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2007-02-09 22:21 Williams, Dan J
2007-02-09 22:33 ` Jeff Garzik
2007-02-10 14:58   ` Tejun Heo
2007-02-10 21:08   ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171063609.29541.6.camel@dwillia2-linux.ch.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=45CCF6BD.9020404@garzik.org \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=jeremy@sgi.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).