From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCHSET] libata: PATA driver for Celleb Date: Tue, 20 Feb 2007 08:43:35 +1100 Message-ID: <1171921415.18571.79.camel@localhost.localdomain> References: <200701260724.l0Q7OISY027645@toshiba.co.jp> <200702151141.49708.jens@de.ibm.com> <20070215171414.GU923@austin.ibm.com> <200702151909.26082.arnd@arndb.de> <20070219215659.15539fb3@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:41635 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932715AbXBSVvT (ORCPT ); Mon, 19 Feb 2007 16:51:19 -0500 In-Reply-To: <20070219215659.15539fb3@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cc: Arnd Bergmann , Linas Vepstas , Jens Osterkamp , linuxppc-dev@ozlabs.org, Jeff Garzik , linux-ide@vger.kernel.org, paulus@samba.org, Andrew Morton , James K Lewis On Mon, 2007-02-19 at 21:56 +0000, Alan wrote: > > I fear that the hardest part is yet to come, when we integrate the > > driver for the the PS3 (currently called gelic_net) into spidernet. > > The trouble is that the hardware is sufficiently similar to share > > all the high-level mechanisms like the DMA data structures and > > descriptor chains, but the low-level mechanisms are hidden in the > > hypervisor on the PS3. Someone will have to invest a significant > > amount of time coordinating this so we don't break celleb and qs20 > > in the process. > > That to me implies they should be different drivers using a common > libata-something file. The PPC mac drivers likewise are currently mashed > into one in drivers/ide but really want splitting for libata with some > kind of libata-pmac owning the shared stuff Also note that for spidernet vs. gelic, I'm actually very tempted to keep them as separate drivers. Ben.