linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 26/46] IDE: remove rwsem use from ide-proc core
       [not found]                                                 ` <11777001301175-git-send-email-gregkh@suse.de>
@ 2007-04-27 18:53                                                   ` Greg Kroah-Hartman
  0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2007-04-27 18:53 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Bartlomiej Zolnierkiewicz, linux ide

The subsystem rwsem is not used by the driver core at all, so the use of
it in the ide-proc code of it doesn't make any sense.  Perhaps a local
lock might be needed, but I do not really think so.

Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux ide <linux-ide@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/ide/ide-proc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index afb71c6..a9e0b30 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -310,14 +310,12 @@ static int proc_ide_read_driver
 	ide_driver_t	*ide_drv;
 	int		len;
 
-	down_read(&dev->bus->subsys.rwsem);
 	if (dev->driver) {
 		ide_drv = container_of(dev->driver, ide_driver_t, gen_driver);
 		len = sprintf(page, "%s version %s\n",
 				dev->driver->name, ide_drv->version);
 	} else
 		len = sprintf(page, "ide-default version 0.9.newide\n");
-	up_read(&dev->bus->subsys.rwsem);
 	PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
 }
 
@@ -327,7 +325,6 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
 	int ret = 1;
 	int err;
 
-	down_write(&dev->bus->subsys.rwsem);
 	device_release_driver(dev);
 	/* FIXME: device can still be in use by previous driver */
 	strlcpy(drive->driver_req, driver, sizeof(drive->driver_req));
@@ -345,7 +342,6 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
 	}
 	if (dev->driver && !strcmp(dev->driver->name, driver))
 		ret = 0;
-	up_write(&dev->bus->subsys.rwsem);
 
 	return ret;
 }
-- 
1.5.1.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-04-27 18:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20070427185152.GA17121@kroah.com>
     [not found] ` <1177700040520-git-send-email-gregkh@suse.de>
     [not found]   ` <11777000433552-git-send-email-gregkh@suse.de>
     [not found]     ` <11777000471977-git-send-email-gregkh@suse.de>
     [not found]       ` <11777000511784-git-send-email-gregkh@suse.de>
     [not found]         ` <11777000552084-git-send-email-gregkh@suse.de>
     [not found]           ` <1177700059319-git-send-email-gregkh@suse.de>
     [not found]             ` <11777000632194-git-send-email-gregkh@suse.de>
     [not found]               ` <11777000663361-git-send-email-gregkh@suse.de>
     [not found]                 ` <1177700070961-git-send-email-gregkh@suse.de>
     [not found]                   ` <1177700074272-git-send-email-gregkh@suse.de>
     [not found]                     ` <11777000773819-git-send-email-gregkh@suse.de>
     [not found]                       ` <11777000814075-git-send-email-gregkh@suse.de>
     [not found]                         ` <11777000852694-git-send-email-gregkh@suse.de>
     [not found]                           ` <11777000881307-git-send-email-gregkh@suse.de>
     [not found]                             ` <11777000923797-git-send-email-gregkh@suse.de>
     [not found]                               ` <11777000963332-git-send-email-gregkh@suse.de>
     [not found]                                 ` <11777001002860-git-send-email-gregkh@suse.de>
     [not found]                                   ` <11777001041847-git-send-email-gregkh@suse.de>
     [not found]                                     ` <11777001072576-git-send-email-gregkh@suse.de>
     [not found]                                       ` <11777001102852-git-send-email-gregkh@suse.de>
     [not found]                                         ` <1177700114535-git-send-email-gregkh@suse.de>
     [not found]                                           ` <11777001182501-git-send-email-gregkh@suse.de>
     [not found]                                             ` <11777001222882-git-send-email-gregkh@suse.de>
     [not found]                                               ` <1177700125350-git-send-email-gregkh@suse.de>
     [not found]                                                 ` <11777001301175-git-send-email-gregkh@suse.de>
2007-04-27 18:53                                                   ` [PATCH 26/46] IDE: remove rwsem use from ide-proc core Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).