From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Kyle McMartin <kyle@mcmartin.ca>
Subject: Re: [PATCH 3/6] ide-pmac: PIO fixes
Date: Fri, 13 Jul 2007 10:52:59 +1000 [thread overview]
Message-ID: <1184287979.6059.165.camel@localhost.localdomain> (raw)
In-Reply-To: <200707122133.09054.bzolnier@gmail.com>
> > This patch should have no effect on the default kernel behavior because
> > IDE pmac driver doesn't enable ->autotune (this would also explain why some
> > of the above bugs remained unfixed for so long).
>
> This part of the patch description is actually incorrect: ->tuneproc is used
> unconditionally during suspend so the patch has the real effect (hopefully
> positive :) on the default kernel behavior.
I need to spend some time looking in details and testing. Thanks for
doing it though. I'll try to get through it next week. Please don't
hesitate to ping me if you don't hear back from me soon.
Ben.
next prev parent reply other threads:[~2007-07-13 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 0:04 [PATCH 3/6] ide-pmac: PIO fixes Bartlomiej Zolnierkiewicz
2007-07-12 19:33 ` Bartlomiej Zolnierkiewicz
2007-07-13 0:52 ` Benjamin Herrenschmidt [this message]
2007-07-13 16:12 ` Sergei Shtylyov
2007-07-13 20:03 ` Bartlomiej Zolnierkiewicz
2007-07-14 16:29 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184287979.6059.165.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=kyle@mcmartin.ca \
--cc=linux-ide@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).